Skip to content

chore: enhance config docs - #6168

Merged
Jiloc merged 9 commits into
stacks-network:developfrom
Jiloc:chore/enhance-config-docs
Jun 16, 2025
Merged

Jiloc merged 9 commits into
stacks-network:developfrom
Jiloc:chore/enhance-config-docs

Conversation

@Jiloc

@Jiloc Jiloc commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Description

This PR contains only formatting changes to the doc comments. The goal is to simplify the format to make it easier to programmatically extract and parse.

Applicable issues

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@Jiloc
Jiloc requested a review from a team June 3, 2025 14:40
@Jiloc
Jiloc requested a review from a team as a code owner June 3, 2025 14:40
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs
Comment thread stackslib/src/config/mod.rs
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs
@wileyj

wileyj commented Jun 3, 2025 •

Copy link
Copy Markdown
Contributor

@Jiloc really good start - i don't envy what you did here, just reading through it was no small task due to the nature of these changes, and as much as i would like to say "let's break this up into several PR's" - that would not be ideal here.

overall, i like the proposed changes - there are a few nits and i think we should define the syntax a little better, possibly adding some more fields to the proposed syntax vs keeping them as normal comment lines. it almost looks like yamldown but not quite - so the rules in the changes can be a bit confusing at first glance. almost like they're oversimplified for brevity, but that leads to a lot of text that won't fit into this syntax (not necessarily a bad thing, but i think this PR needs to be explicit on what the syntax is, and how it should be applied consistently).

i would also like to hear about how these changes will help with parsing/extracting/rendering these comments to some output that can be consumed. for example, if there is a process or tool in mind, that could help inform what the syntax should look like globally.

edit: several of my comments above can be applied throughout the diff, but to reduce noise and repeating myself i've only marked a few examples where i think a change would be appropriate, with the expectation that later instances would use the same changes/rules.

@Jiloc Jiloc self-assigned this Jun 3, 2025
@Jiloc Jiloc moved this to Status: In Review in Stacks Core Eng Jun 3, 2025
@wileyj

wileyj commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

#6171

@Jiloc Jiloc mentioned this pull request Jun 3, 2025
5 tasks
@Jiloc
Jiloc requested a review from fdefelici June 3, 2025 22:18
@aldur aldur added this to the 3.1.0.0.13 milestone Jun 4, 2025
@wileyj

wileyj commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

https://github.com/Jiloc/stacks-core/blob/feat/config-docs-generator/docs/generated/configuration-reference.md

thanks! i think the syntax definition is fine to leave in #6171

in light of that, i'll check and resolve some existing comments here that may now be answered with that def.

Comment thread stackslib/src/config/mod.rs Outdated
Comment thread stackslib/src/config/mod.rs
Comment thread stackslib/src/config/mod.rs
hstove
hstove previously approved these changes Jun 11, 2025

@hstove hstove left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@aldur
aldur requested a review from wileyj June 12, 2025 14:53
fdefelici
fdefelici previously approved these changes Jun 12, 2025

@fdefelici fdefelici left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt!

@Jiloc
Jiloc dismissed stale reviews from fdefelici and hstove via 3790bb8 June 13, 2025 09:20
@aldur
aldur requested review from fdefelici and hstove June 13, 2025 15:32
@codecov

codecov Bot commented Jun 13, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.60%. Comparing base (2493ed1) to head (3790bb8).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6168      +/-   ##
===========================================
+ Coverage    77.27%   83.60%   +6.32%     
===========================================
  Files          545      545              
  Lines       392359   392359              
  Branches       323      323              
===========================================
+ Hits        303184   328017   +24833     
+ Misses       89167    64334   -24833     
  Partials         8        8              
Files with missing lines Coverage Δ
stackslib/src/config/mod.rs 73.39% <ø> (+1.36%) ⬆️

... and 203 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2493ed1...3790bb8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation Bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Jun 16, 2025
@Jiloc
Jiloc added this pull request to the merge queue Jun 16, 2025
Merged via the queue into stacks-network:develop with commit 202bc61 Jun 16, 2025
@Jiloc
Jiloc deleted the chore/enhance-config-docs branch June 16, 2025 15:09
@github-project-automation github-project-automation Bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Jun 16, 2025
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants