Repository navigation
Update babel and unicorn majors, and cache apt packages in CI - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Major updates from #8. This takes @babel/core 7 → 8 and eslint-plugin-unicorn 77 → 79, plus the two lint fixes the new unicorn rules ask for. Dependabot's #8 fails lint without those fixes, and it closes on its own once this merges.
inInputis renamed toisInInput(unicorn/consistent-boolean).Moduletype in the plugin sandbox moves insidemakeRequire, the only place it's used (unicorn/prefer-smaller-scope).Slow Ubuntu jobs. The "Install Linux dependencies" step sometimes took 20 minutes because the runner's apt mirror was slow. CI and Release now use
awalsh128/cache-apt-pkgs-action, which restores the packages from the Actions cache after the first run. The package lists haven't changed.Tested on
Linux (sandbox):
pnpm lint,pnpm typecheck,pnpm format:checkandpnpm buildpass with babel 8 and unicorn 79. The workflow change is verified by this PR's own CI run. The first run fills the cache, and later runs should skip most of the download.pnpm typecheck,pnpm lint,pnpm format:checkpass