Repository navigation
Give the {} event shorthand an empty-object JSON Schema - #153
Merged
Merged
Conversation
Events declared as `{}` normalize to a hand-rolled statelyai-agent Standard
Schema with no JSON Schema extension, so offering one to a model through
createAiSdkExecutors' decide path threw "Standard schema vendor
'statelyai-agent' does not support JSON Schema conversion." The schema now
exposes ~standard.jsonSchema.input() returning an empty object schema.
🦋 Changeset detectedLatest commit: 45d6383 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An event declared with the
{}shorthand insetupAgent({ events: { APPROVE: {} } })and listed inagent.decide({ allowedEvents })madecreateAiSdkExecutorsfail:The shorthand normalizes to a hand-rolled Standard Schema in
src/setup-agent.ts. The AI SDK'sasSchemaconverts non-zod Standard Schemas only through the~standard.jsonSchema.input()extension, which that schema lacked.Fix
emptyEventSchemanow exposesjsonSchema.input()returning{ type: "object", properties: {}, additionalProperties: false }, the same pattern the adapter's own fallbackunknownSchemainsrc/ai-sdk/mappers.tsalready uses.Test
End-to-end test in
src/ai-sdk/index.test.ts:{}event →agent.decide({ allowedEvents })→createAiSdkExecutorswith a mock model capturing the tool's input schema. Reproduced the exact error before the fix.Patch changeset included.
pnpm vitest --run src, typecheck, lint, format all green.