Skip to content

Fix CI: bump SourceLink to clear NU1902 audit failure - #1

Merged
davidkpiano merged 2 commits into
mainfrom
davidkpiano/ci-issues-7412c0
Sep 11, 2026
Merged

davidkpiano merged 2 commits into
mainfrom
davidkpiano/ci-issues-7412c0

Conversation

@davidkpiano

@davidkpiano davidkpiano commented Sep 11, 2026

Copy link
Copy Markdown
Member

CI on main fails at restore: NU1902 (Microsoft.Build.Tasks.Git 8.0.0, GHSA-23fw-v26w-5fgq) is elevated to an error by TreatWarningsAsErrors. Bumps Microsoft.SourceLink.GitHub 8.0.0 → 10.0.401; dotnet list package --vulnerable --include-transitive is now clean. Also corrects a stale comment in ci.yml about test TFMs.

Verified locally: restore, Release build, net10.0 tests (285 + 443 passed, 0 skipped), pack.


Devin Review

Summary by CodeRabbit

  • Chores
    • Updated build and test automation to support projects targeting multiple .NET versions.
    • Refined source-linking configuration to improve consistency in build outputs and debugging workflows.
    • No end-user-facing functionality or interface changes were introduced.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: abaeb90c-a2dd-49ac-9e61-d524eef92685

📥 Commits

Reviewing files that changed from the base of the PR and between 5b696c0 and 495982c.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • Directory.Build.props

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The shared build configuration updates Microsoft.SourceLink.GitHub to 10.0.401. The CI workflow documents that tests require both .NET 8.x and .NET 10.x SDKs.

Changes

Build and CI toolchain alignment

Layer / File(s) Summary
Toolchain configuration updates
.github/workflows/ci.yml, Directory.Build.props
The CI documentation reflects multi-targeted net8.0;net10.0 tests. The shared SourceLink package reference changes from 8.0.0 to 10.0.401.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 49598

The toolchain update and CI documentation are consistent, with verification passing and no unresolved merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary changes: the SourceLink update and the CI audit failure fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch davidkpiano/ci-issues-7412c0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread .github/workflows/ci.yml
@davidkpiano
davidkpiano merged commit 2249867 into main Sep 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant