Skip to content

fix: ship tool updates with explicit timezone data - #6123

Merged
stranske merged 1 commit into
mainfrom
codex/dependency-closeout-20261022
Oct 23, 2026
Merged

stranske merged 1 commit into
mainfrom
codex/dependency-closeout-20261022

Conversation

@stranske

Copy link
Copy Markdown
Owner

The selected tool updates expose timezone tests on runners without system timezone files. Add tzdata as a runtime dependency and lock its resolved version while preserving all existing locked versions. Focused timezone, data-contract and pipeline tests pass with PYTHONTZPATH=/nonexistent: 20 passed.

Supersedes #6122 after successful merged delivery.

Tasks

  • Retain the selected dependency updates.
  • Fix the concrete delivery blocker with focused validation.

Acceptance Criteria

  • Relevant local checks pass.
  • Required native CI and exact-head review gates pass.
  • Verify merged delivery before closing the superseded PR.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-22T23:52:19.957577Z 55f4617 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between fc43c30 and 55f4617.

⛔ Files ignored due to path filters: 1
  • requirements.lock is excluded by !**/*.lock, !**/*.lock
📒 Files selected for processing: 3
  • .github/workflows/autofix-versions.env
  • .pre-commit-config.yaml
  • pyproject.toml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the versions of Ruff and Coverage used by the project.
    • Added timezone data support to the project.

The project adds tzdata>=2025.2 and updates Ruff and Coverage pins in project and workflow configuration.

Changes: Dependency updates

Layer / File(s) Summary
Add the tzdata dependency
pyproject.toml
Adds tzdata to the project dependencies with a minimum version of 2025.2.
Update development tool pins
pyproject.toml, .pre-commit-config.yaml, .github/workflows/autofix-versions.env
Updates Ruff to 0.17.2 and Coverage to 7.17.0 in development and workflow pins. The pre-commit Ruff revision changes to v0.17.2.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

Merge Risk: ⚪ Minimal · up to 55f46

The dependency and development-tool updates are mergeable with no established current-head risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly summarizes the main changes: tool updates and explicit timezone data support.
Description check Passed The description directly explains the tzdata dependency, tool updates, validation results, and delivery status.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@stranske
stranske merged commit 9be0760 into main Oct 23, 2026
36 checks passed
@stranske
stranske deleted the codex/dependency-closeout-20261022 branch October 23, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant