Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions accessors.go
Original file line number Diff line number Diff line change
Expand Up @@ -202,3 +202,58 @@ func interSlice(slice interface{}) ([]interface{}, bool) {

return ret, true
}

// has checks whether the specified selector exists within the object.
func has(current interface{}, selector string) bool {
thisSel, nextSel := getKey(selector)

indexes := []int{}
for strings.Contains(thisSel, "[") {
prevSel := thisSel
index := -1
index, thisSel = getIndex(thisSel)
indexes = append(indexes, index)
if prevSel == thisSel {
break
}
}

if curMap, ok := current.(Map); ok {
current = map[string]interface{}(curMap)
}

switch cur := current.(type) {
case map[string]interface{}:
val, ok := cur[thisSel]
if !ok {
return false
}
current = val
default:
return false
}

if len(indexes) > 0 {
num := len(indexes)
for num > 0 {
num--
index := indexes[num]
indexes = indexes[:num]
if array, ok := interSlice(current); ok {
if index >= 0 && index < len(array) {
current = array[index]
} else {
return false
}
} else {
return false
}
}
}

if nextSel != "" {
return has(current, nextSel)
}

return true
}
2 changes: 1 addition & 1 deletion tests.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ func (m Map) Has(selector string) bool {
if m == nil {
return false
}
return !m.Get(selector).IsNil()
return has(m, selector)
}

// IsNil gets whether the data is nil or not.
Expand Down
43 changes: 43 additions & 0 deletions tests_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,46 @@ func TestHas(t *testing.T) {

assert.False(t, m.Has("nothing"))
}

func TestHasWithNil(t *testing.T) {
m := objx.Map{
"nilField": nil,
"nested": objx.Map{
"nilChild": nil,
"valid": "hello",
},
"nilSlice": []interface{}{nil, "value"},
}

assert.True(t, m.Has("nilField"))
assert.True(t, m.Has("nested.nilChild"))
assert.True(t, m.Has("nested.valid"))
assert.True(t, m.Has("nilSlice[0]"))
assert.True(t, m.Has("nilSlice[1]"))

assert.False(t, m.Has("nonExistent"))
assert.False(t, m.Has("nested.nonExistent"))
assert.False(t, m.Has("nilSlice[2]"))
assert.False(t, m.Has("nilField.child"))
assert.False(t, m.Has("nilSlice[0].child"))

// Verify we can differentiate nil value from not found
assert.True(t, m.Has("nilField"))
assert.True(t, m.Get("nilField").IsNil())

assert.False(t, m.Has("nonExistent"))
assert.True(t, m.Get("nonExistent").IsNil())
}

func TestHasDifferentiateNilFromNotFound(t *testing.T) {
obj := objx.Map(map[string]interface{}{
"foo": map[string]interface{}{
"bar": 5,
"baz": nil,
},
})

assert.True(t, obj.Has("foo.bar"))
assert.True(t, obj.Has("foo.baz"))
assert.False(t, obj.Has("foo.qux"))
}
Loading