feat: add SF_CONTROLLER_DEBUG env var for WebSocket lifecycle debug logging - #3
Open
cavonlee wants to merge 2 commits into
Open
feat: add SF_CONTROLLER_DEBUG env var for WebSocket lifecycle debug logging#3cavonlee wants to merge 2 commits into
cavonlee wants to merge 2 commits into
Conversation
added 2 commits
July 29, 2026 17:47
- Add _debug() helper controlled by SF_CONTROLLER_DEBUG=1 - Log connection, recv (content+bytes), send (payload+bytes), parse, errors, close - Fix stale tmp reference across recv timeout by resetting tmp=None each iteration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add debug logging toggle via
SF_CONTROLLER_DEBUG=1env var to trace fullWebSocket lifecycle in sunfounder_controller.
Why
Android App connects successfully (WS handshake OK, camera stream OK) but
joystick/button data never arrives. Need to debug the comms pipeline without
modifying user code.
Changes
_debug()helper prints timestamped messages only whenSF_CONTROLLER_DEBUG=1tmpreference: resettmp = Noneeach iteration to avoid reusing old data after recv timeoutUsage
Tested