Design 2 - #2489
Open
Yashzaparto wants to merge 1 commit into
Open
Conversation
Owner
Implement Queue using Stacks (queue_using_stacks.py)Great job! Your solution correctly implements a queue using two stacks with the optimal amortized O(1) approach. The logic is clean and the code is readable. A few minor suggestions:
def _transfer(self):
while self.in_stack:
self.out_stack.append(self.in_stack.pop())
Overall, this is a solid solution that demonstrates a clear understanding of the problem. VERDICT: PASS Design HashMap (design_hashmap.py)Strengths:
Areas for improvement:
VERDICT: PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.