Move the remaining compact app lookups to Flaps and trim the client - #5188
Merged
lillianberryfly merged 1 commit intoSep 8, 2026
Merged
Conversation
The flypg SSH command, postgres config update and events, the machine deletion hook, the secrets and consul commands, doctor, and machine run fetch the app through Flaps and the organization through ui-ex. The flypg command takes the org explicitly since it issues SSH certificates. DeploySecrets takes an app name and looks the app up itself, so the extension commands no longer build a compact app from an add-on record. doctor derives the app hostname from its name, which is how the API computes it. Only status --json still uses the compact app query, since it prints the struct. Remove the 36 methods on the GraphQL client interface that no longer have callers, along with their mock and in-memory implementations, the dead members of the deploy and logs sub-interfaces, and the unused compact app conversion. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DMttEkUAVhL7YZFRFjhHwB
dangra
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flypg SSH command, postgres config update and events, the machine deletion hook, the secrets and consul commands, doctor, and machine run fetch the app through Flaps and the organization through ui-ex. The flypg command takes the org explicitly since it issues SSH certificates. DeploySecrets takes an app name and looks the app up itself, so the extension commands no longer build a compact app from an add-on record. doctor derives the app hostname from its name, which is how the API computes it. Only status --json still uses the compact app query, since it prints the struct.
Remove the 36 methods on the GraphQL client interface that no longer have callers, along with their mock and in-memory implementations, the dead members of the deploy and logs sub-interfaces, and the unused compact app conversion.
Claude-Session: https://claude.ai/code/session_01DMttEkUAVhL7YZFRFjhHwB