fix(mcp): write MCP client configuration at 0600 - #5192
Merged
Conversation
fly mcp add with --stream or --sse records the Fly API token in the client configuration as a --bearer-token argument, and the file was written world-readable. Write it owner-only, matching flyctl's own config file, and apply the mode on rewrite as well since os.WriteFile only sets it on creation.
Lucais11
approved these changes
Sep 8, 2026
Lucais11
left a comment
Lucais11
left a comment
Contributor
There was a problem hiding this comment.
Looks right and seems consistent with the configureDockerJSON pattern we already use. I also double checked that Chmod is load-bearing by dropping it, which then fails two of the new tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fly mcp add with --stream or --sse records the Fly API token in the client configuration as a --bearer-token argument, and the file was written world-readable. Write it owner-only, matching flyctl's own config file, and apply the mode on rewrite as well since os.WriteFile only sets it on creation.