chore: bundle adapter-node's server source directly instead of prebuilding it with rolldown - #17109
Open
Nic-Polumeyv wants to merge 6 commits into
Open
Nic-Polumeyv wants to merge 6 commits into
Nic-Polumeyv wants to merge 6 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/ba6ab38dedca945fcd4815835e465273ec89f8e4Open in |
🦋 Changeset detectedLatest commit: ba6ab38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nic-Polumeyv
force-pushed
the
adapter-node-drop-prebuild
branch
2 times, most recently
from
September 14, 2026 23:38
e308b55 to
ccfa2ce
Compare
Nic-Polumeyv
force-pushed
the
manifest-static-assets
branch
2 times, most recently
from
September 14, 2026 23:51
6a1bf95 to
a025f33
Compare
Nic-Polumeyv
force-pushed
the
adapter-node-drop-prebuild
branch
from
September 14, 2026 23:51
ccfa2ce to
348f74f
Compare
Nic-Polumeyv
force-pushed
the
manifest-static-assets
branch
from
September 14, 2026 23:59
a025f33 to
36b547b
Compare
Nic-Polumeyv
force-pushed
the
adapter-node-drop-prebuild
branch
from
September 14, 2026 23:59
348f74f to
c6538b5
Compare
Nic-Polumeyv
added this pull request to stack #17110
September 15, 2026 00:09
Nic-Polumeyv
marked this pull request as ready for review
September 15, 2026 00:14
Rich-Harris
approved these changes
Sep 15, 2026
Rich-Harris
added
the
needs-platform-tests
Nic-Polumeyv
removed this pull request from stack #17110
September 17, 2026 19:30
Nic-Polumeyv
force-pushed
the
adapter-node-drop-prebuild
branch
from
September 17, 2026 19:32
23fd551 to
e4d272b
Compare
Nic-Polumeyv
force-pushed
the
manifest-static-assets
branch
from
September 17, 2026 19:32
7b933e3 to
28d211a
Compare
Nic-Polumeyv
added this pull request to stack #17126
September 17, 2026 19:32
teemingc
force-pushed
the
manifest-static-assets
branch
from
September 18, 2026 20:39
28d211a to
3b68018
Compare
Nic-Polumeyv
force-pushed
the
adapter-node-drop-prebuild
branch
from
September 18, 2026 22:39
e4d272b to
e39f45e
Compare
Nic-Polumeyv
removed this pull request from stack #17126
September 19, 2026 13:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adapter-node prebuilds its server source with rolldown into
files/and points the app's Vite build at that output. The only reason was to vendor devDependencies like sirv into the adapter, since a consumer'snode_modulescannot resolve them. With #16908 the source imports nothing but Node builtins,@sveltejs/kit/nodeand the hand-off module from #17103, all of which the app's own build resolves.This points the Vite inputs at
src/and deletes the prebuild: the rolldown config and dependency, the build scripts, the CI step that ran them, and the two test fixtures that guarded chunk patching and specifier interception, neither of which exists now.Stacked on #16908.