Skip to content

chore: run each platform test variant through one reusable workflow - #17173

Merged
teemingc merged 6 commits into
version-3from
platform-tests-reusable-workflow
Sep 23, 2026
Merged

teemingc merged 6 commits into
version-3from
platform-tests-reusable-workflow

Conversation

@Nic-Polumeyv

Copy link
Copy Markdown
Contributor

The version-3 half of #17171: one reusable workflow called per variant replaces the six per-platform workflows and four actions, with the Bun and Netlify instrumentation tests kept.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 106b495:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/106b4952f8fc2a75539046f91fd164c645316b0f

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17173

@changeset-bot

changeset-bot Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 106b495

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread .github/workflows/platform-test.yml Dismissed
@svelte-docs-bot

Copy link
Copy Markdown

Comment thread .github/workflows/platform-test.yml Fixed
@Nic-Polumeyv
Nic-Polumeyv force-pushed the platform-tests-reusable-workflow branch from e31d51c to 832e6ae Compare September 21, 2026 05:06
@Nic-Polumeyv
Nic-Polumeyv force-pushed the platform-tests-reusable-workflow branch from 832e6ae to 9c4194b Compare September 21, 2026 05:08
@Nic-Polumeyv
Nic-Polumeyv marked this pull request as ready for review September 21, 2026 05:08
@Nic-Polumeyv
Nic-Polumeyv had a problem deploying to @sveltejs/adapter-netlify platform tests September 21, 2026 15:03 — with GitHub Actions Failure
@Nic-Polumeyv
Nic-Polumeyv had a problem deploying to @sveltejs/adapter-netlify platform tests September 21, 2026 15:04 — with GitHub Actions Failure
@Nic-Polumeyv
Nic-Polumeyv had a problem deploying to @sveltejs/adapter-netlify platform tests September 21, 2026 15:04 — with GitHub Actions Failure
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-netlify platform tests September 21, 2026 15:04 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv had a problem deploying to @sveltejs/adapter-netlify platform tests September 21, 2026 15:04 — with GitHub Actions Failure
@teemingc

Copy link
Copy Markdown
Member

I was a bit confused because the changes differ a little from the ones on main. This PR combines more of the steps into a single file.

could we merge #17176 then #17164 before this one?

Nic-Polumeyv and others added 3 commits September 23, 2026 13:26
@Nic-Polumeyv

Nic-Polumeyv commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor Author

This now has the step names from #17176 and your vercel.json removal, so it doesn't need to wait on either. #17164 deletes node-test while platform-tests-bun.yml still uses it and drops the instrumentation and Windows node legs, so I think it makes sense to close it in favor of this one

@teemingc

Copy link
Copy Markdown
Member

#17164 also resolves the merge conflicts between main and version-3

@Nic-Polumeyv

Copy link
Copy Markdown
Contributor Author

Could this go in first then? #17164 can keep version-3's side for the platform workflows, so the bun break never lands.

@teemingc teemingc added the needs-platform-tests This PR needs to run platform tests in order to merge. label Sep 23, 2026
@teemingc
teemingc merged commit bf6833a into version-3 Sep 23, 2026
38 of 40 checks passed
@teemingc
teemingc deleted the platform-tests-reusable-workflow branch September 23, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-platform-tests This PR needs to run platform tests in order to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants