Skip to content

fix(policy): reject committed private files instead of mentions - #39

Merged
showxu merged 1 commit into
masterfrom
fix/policy-commit-paths
Oct 18, 2026
Merged

showxu merged 1 commit into
masterfrom
fix/policy-commit-paths

Conversation

@showxu

@showxu showxu commented Oct 18, 2026

Copy link
Copy Markdown
Member

Reject committed private execution files instead of text that mentions them.

The source policy rejected any added line mentioning .agent/, PLANS.md or *.plan.md. Its intent is that private execution files never enter these public repositories, but the check also blocked documentation that describes those conventions. For example, a planning skill cannot name where agent plans live without failing.

  • Added-line content still rejects attribution trailers, unapproved product terms, absolute personal paths and .workspace/ paths. Mentions of .agent/, PLANS.md and *.plan.md are allowed.
  • Changed file paths are now checked: an added or modified file is rejected when any path segment is .agent or .workspace, or its basename is PLANS.md or ends with .plan.md. Deleting such a file is allowed.
  • The embedded checker in the reusable workflow is regenerated, and WorkflowIntegration and MAINTENANCE describe the new rule.

Every local consumer checkout was surveyed: none tracks a file the new path rule would reject on modification.

Validation: 67 unit tests, Scripts/check (generated copies, profile, actionlint) and diff checks passed. An independent read-only review found no functional defects; its coverage suggestions are included as tests. A consumer run against this commit is linked below once it completes.

Risk: medium. Shared policy used by every consuming repository; behavior becomes less strict for text and stricter for committed paths.

@showxu
showxu merged commit ee5e95f into master Oct 18, 2026
3 checks passed
@showxu
showxu deleted the fix/policy-commit-paths branch October 18, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant