Repository navigation
Use the real host for SERVER_NAME in the TYPO3 driver - #10
Merged
Merged
Conversation
The TYPO3 driver hardcoded $_SERVER['SERVER_NAME'] = $siteName.'.dev', a stale default from when Valet's TLD was .dev (changed to .test in 2018). For a site served at foo.test the app saw SERVER_NAME 'foo.dev'. Set it from the actual request host instead, matching every other driver (Basic, Magento2, Kirby, Craft, ...).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase-1 finding F-1.3 (actionable part).
The TYPO3 driver hardcoded
$_SERVER['SERVER_NAME'] = $siteName.'.dev'— a stale default from when Valet's TLD was.dev(switched to.testin 2018). A site atfoo.testsawSERVER_NAME = foo.dev. Set it from the actual request host ($_SERVER['HTTP_HOST']), matching every other driver.The broader host-header →
SERVER_NAMEpropagation (common to all drivers and upstream) is standard web-server behavior and left as-is — apps remain responsible for trusted-host validation, as with any PHP app.Full suite: 316 tests, phpstan green, php-cs-fixer clean.