Repository navigation
Sync safe fixes from upstream laravel/valet - #2
Merged
Merged
Conversation
Port low-risk, platform-agnostic fixes from laravel/valet v4.12.0: - server.php: unset Valet internals ($valetConfig, $valetSitePath, etc.) before including the front controller, so they no longer leak into the user application's global scope. - server.php / Server.php: use require instead of require_once for the front controller and the 404 template, which are meant to run every request. - ValetDriver: load .valet-env.php with include instead of include_once, so a second call returns the variables array rather than int(1). - CraftValetDriver: unset $_SERVER['argv'] in frontControllerPath() so Craft does not mis-detect console mode under the web SAPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports low-risk, platform-agnostic fixes from laravel/valet v4.12.0.
unset()Valet internals ($valetConfig,$valetSitePath, …) before including the front controller, so they no longer leak into the user application's global scope.requireinstead ofrequire_oncefor the front controller and the 404 template (meant to run every request)..valet-env.phpwithincludeinstead ofinclude_once(a second call otherwise returnsint(1)instead of the variables array).unset($_SERVER['argv'])infrontControllerPath()so Craft doesn't mis-detect console mode under the web SAPI.Full suite green (224 tests at the time of this branch).