Skip to content

ShareWindow not shown when clicking Share in the player outside of show pages #2166

Description

@2u841r

The share button in the audio player (Player.svelte) triggers episode_share_status, but the ShareWindow component that listens to that state is only mounted inside src/routes/(site)/show/[show_number]/[slug]/+layout.svelte.

As a result, clicking the share button in the player on the homepage (or any page that isn't a show page) does nothing — the modal never appears.

Expected behavior:
The share modal opens regardless of which page you're on.

Suggested fix:
Move ShareWindow into the site-wide layout so it's available on all pages where the player can be active.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions