Repository navigation
fix(deps): upgrade effect to 4.1.2 - #4
Merged
Merged
Conversation
![kiro-systemf[bot]](https://avatars.githubusercontent.com/u/172220390?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewed at 5a16a44. The two source changes preserve success/failure boolean semantics using Effect.isSuccess/isFailure. Catalog/peer bounds require Effect 4.1.2; tsgo moves to 0.64.1 with regenerated lockfile and patch intents for both affected packages. Existing static checks, affected tests and check:ci pass. Real-microVM smoke is skipped, not claimed as verified. The prior reviewer-lane profile refusal does not replace this conductor review.
Conductor own review of effect-microvm#4 source and dependency diff
|
@Mergifyio queue |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The published microVM packages now require Effect ^4.1.2. Their direct Effect dependencies resolve to 4.1.2; @effect/tsgo resolves to 0.64.1.
The existing @effect/tsgo override remains because the shared oxlint preset still declares an older 0.x range (SYS-990). Transitive Stryker packages still resolve effect and @effect/platform-node/platform-node-shared 4.1.0; @effect/opentelemetry 4.1.2 also has a transitive Effect 4.1.0 peer context. Those dependencies are updated in their source repositories, not overridden here (SYS-1075).
The
effecttsgo(match-boolean-to-is-success)lint rule required both source edits:writeChunkOfinmicro-vm.medium.tsnow usesEffect.isSuccess, andrecordGoneinboot-alpine.tsusesEffect.isFailure.packages/effect-daemon-microvm/src/MicroVMMedium/micro-vm.medium.ts:effecttsgo(match-boolean-to-is-success)at@effect/tsgo0.64.1 required changing booleanEffect.matchtoEffect.isSuccess(same rule and fix as effect-memfs#3).packages/effect-microsandbox/examples/boot-alpine.ts:effecttsgo(match-boolean-to-is-success)at@effect/tsgo0.64.1 required changing booleanEffect.matchtoEffect.isFailure(same rule and fix as effect-memfs#3).Related to SYS-1062.
Verification
nix develop --command pnpm check:localpassed before and after the upgrade.