Quick docs updates, Rust Edition 2024, bump version for release - #1008
Merged
Conversation
dralley
commented
Aug 22, 2026
| let mut iter = (offset..).zip(slice[offset..].iter()); | ||
|
|
||
| match iter.find(|(_, &b)| is_whitespace(b)) { | ||
| match iter.find(|&(_, &b)| is_whitespace(b)) { |
Collaborator
Author
There was a problem hiding this comment.
From cargo fix --edition
dralley
commented
Aug 22, 2026
| //! |------------------------------|----------------------------------------------| | ||
| //! | attribute `id="..."` | `#[serde(rename = "@id")]` | | ||
| //! | text inside an element | `#[serde(rename = "$text")]` | | ||
| //! | element presence | `#[serde(rename = "$value")]` | |
Collaborator
Author
There was a problem hiding this comment.
Not sure if this is the best description
Collaborator
There was a problem hiding this comment.
That will be better because that is common usage of this rename
Suggested change
| //! | element presence | `#[serde(rename = "$value")]` | | |
| //! | xs:choice as Rust enum | `#[serde(rename = "$value")]` | |
Collaborator
Author
|
|
Mingun
approved these changes
Aug 22, 2026
| //! |------------------------------|----------------------------------------------| | ||
| //! | attribute `id="..."` | `#[serde(rename = "@id")]` | | ||
| //! | text inside an element | `#[serde(rename = "$text")]` | | ||
| //! | element presence | `#[serde(rename = "$value")]` | |
Collaborator
There was a problem hiding this comment.
That will be better because that is common usage of this rename
Suggested change
| //! | element presence | `#[serde(rename = "$value")]` | | |
| //! | xs:choice as Rust enum | `#[serde(rename = "$value")]` | |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
==========================================
- Coverage 57.31% 55.27% -2.04%
==========================================
Files 46 51 +5
Lines 18197 18723 +526
==========================================
- Hits 10429 10349 -80
- Misses 7768 8374 +606
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Our MSRV is 1.86 - 1.85 introduced Rust 2024 Edition. Therefore we can bump the edition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.