Skip to content

Use dedicated type for Comment event - #1009

Merged
dralley merged 4 commits into
tafia:masterfrom
Mingun:split-of-comment
Aug 23, 2026
Merged

Use dedicated type for Comment event#1009
dralley merged 4 commits into
tafia:masterfrom
Mingun:split-of-comment

Conversation

@Mingun

@Mingun Mingun commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

The dedicated type provides two improvements:

  • it is validated at creation time that comment does not contain --> inside
  • it may contain comment-specific methods (I plan to add .validate() method for Validation API that will check for absence of -- inside)

@Mingun
Mingun requested a review from dralley August 23, 2026 13:22
@codecov-commenter

codecov-commenter commented Aug 23, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 32.75862% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.19%. Comparing base (e00ae5c) to head (86f7d40).
⚠️ Report is 69 commits behind head on master.

Files with missing lines Patch % Lines
src/events/mod.rs 30.35% 39 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
- Coverage   57.31%   55.19%   -2.12%     
==========================================
  Files          46       51       +5     
  Lines       18197    18779     +582     
==========================================
- Hits        10429    10366      -63     
- Misses       7768     8413     +645     
Flag Coverage Δ
unittests 55.19% <32.75%> (-2.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Mingun added 2 commits August 23, 2026 18:48
This will allow to add specific methods for comments in the future
@dralley
dralley merged commit 5d5a4e9 into tafia:master Aug 23, 2026
7 checks passed
@Mingun
Mingun deleted the split-of-comment branch August 23, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants