Use dedicated type for Comment event - #1009
Merged
Merged
Conversation
Mingun
force-pushed
the
split-of-comment
branch
from
August 23, 2026 13:23
ad71f32 to
aef2341
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
- Coverage 57.31% 55.19% -2.12%
==========================================
Files 46 51 +5
Lines 18197 18779 +582
==========================================
- Hits 10429 10366 -63
- Misses 7768 8413 +645
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This will allow to add specific methods for comments in the future
Mingun
force-pushed
the
split-of-comment
branch
from
August 23, 2026 13:51
aef2341 to
86f7d40
Compare
dralley
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dedicated type provides two improvements:
-->inside.validate()method for Validation API that will check for absence of--inside)