Implement PartialEq<str> on Namespace, Prefix and LocalName

[Tpt]

Allows to easily write comparisons on both

[dralley]

Once you've fixed the test failures, please add a changelog entry also.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.11%. Comparing base (e00ae5c) to head (ffb7a97).
⚠️ Report is 74 commits behind head on master.

Files with missing lines	Patch %	Lines
src/name.rs	0.00%	18 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
- Coverage   57.31%   55.11%   -2.20%     
==========================================
  Files          46       51       +5     
  Lines       18197    18809     +612     
==========================================
- Hits        10429    10366      -63     
- Misses       7768     8443     +675     

Flag	Coverage Δ
unittests	55.11% <0.00%> (-2.20%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Tpt]

@dralley Thank you! Done. I have also added a changelog line for the previous MR you merged (thank you for it)

[Mingun]

Not sure about it. Wouldn't it defeat the idea to have distinct types for different things? Now you may compare local name with something with colon, which is definitely will be false.

[dralley]

Not sure about it. Wouldn't it defeat the idea to have distinct types for different things? Now you may compare local name with something with colon, which is definitely will be false.

You could, but it feels like the same class of error as, say, calling .into_inner() or Deref or format!() on a BytesText without normalizing / unescaping first. Or passing escaped text into a constructor that does escaping (again). Things that could happen, but is prevention really worth the cost? (and thus we don't really try to prevent it)

I see your point though. I think you can make reasonable arguments either way.. I guess I fall slightly on the side of the ergonomic argument personally given it's documented and most novice users would pick .name() over .local_name() if they were being lazy. But I don't feel strongly about it.

If we were to not change it, the examples should at least be using LocalName("tag1"), which is slightly cleaner and shorter than QName("tag1").into()

The internal field is only pub(crate), so I guess not. That would have the same issue anyway, if it were public - being able to pass myns:tag1