Repository navigation
Fold not-null tests in index expressions and predicates - #1624
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_relation_inforunseval_const_expressionson the index expressions and the predicate again with the planner's root, so aNullTestof a column innotnullattnumsreduces to a constant. rupg folded them with an empty query, so the tests stayed and the indexes ofpredicate.sql(pred_tab_exprs_idx,pred_tab_pred_idx) were not used.indexesinconnection/explain.rsreplacesIS [NOT] NULLof a column with a valid not-null constraint (not a row type) bytrue/falsebefore the fold.trueis dropped, andpartialnow follows the folded predicate, asindpredbecomesNILin PostgreSQL.Test
index_null_reduce: the fixture is the output of PostgreSQL 19 for the same script (expression index, predicate index,WHERE b IS NULLon a not-null column, and a nullable column whose test stays).btcost_correlationof an index whose first key is an expression now reads the correlation from the statistics of the index, asexamine_indexcol_variabledoes; rupg read only table columns, so such an index scan cost twice PostgreSQL's (16.22 against 8.60) and lost to a bitmap scan.