fix(deps): resolve open Dependabot alerts - #360
Merged
Conversation
Complete the interrupted remediation. yarn resolutions already staged in the prior commit cover 14 of 17 alerts (decode-uri-component, postcss-selector-parser, qs, serialize-javascript, tough-cookie, undici, uuid); verified the lockfile is consistent (yarn install: already up-to-date) and all gates pass. Revert the solidity-fixtures submodule pointer to origin/main: the interrupted run pinned it to a newer upstream commit as a side effect of `git submodule update --init --recursive`, unrelated to Dependabot. Left open (no patched version available, and each is a deep transitive dependency of circomlibjs/web3, which is actively used for Poseidon hashing and merkle-tree utilities - not safely removable): - request (moderate, alert #78) - web3-core-subscriptions (low, alert #183) - elliptic (low, alert #198)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the interrupted Dependabot remediation for SOC 2 Vanta Request 7. All 14 fixable alerts are resolved via
resolutionsinpackage.json(minimal version bumps, regeneratedyarn.lock); 3 alerts have no patched version upstream and are left open (documented below).Alerts addressed (14)
(undici and uuid each cover multiple alert numbers for the same package/vulnerability family.)
Alerts left open (3) — no patched version available
circomlibjs→web3→web3-bzz→swarm-js→eth-lib→servify.circomlibjsis actively used for Poseidon hashing/merkle-tree utilities acrosspackages/utils,packages/anchors, and contract tests — not safely removable.circomlibjs→web3transitive chain (web3-eth,web3-shh,web3-core).ethers'@ethersproject/signing-key(used throughout the codebase) and of thecircomlibjs/web3/eth-libchain.Also fixed
The interrupted WIP commit had accidentally bumped the
solidity-fixturesgit submodule pointer to a newer upstream commit as a side effect ofgit submodule update --init --recursive(submodule tracksmain, no pin). That's unrelated to Dependabot remediation; reverted it back to the commit pinned onmain.Gates run
npx hardhat testrepresentative subset (full ZK-proof suite is multi-minute per file; ran the files that exercise the bumped deps most directly — ethers signing,circomlibjs/Poseidon, ganache/web3 deployment path):Pre-existing flaky fuzz test (not caused by this change)
forge testfailed once onVAnchorHandlerTest.test_anchorUpdateShouldFailIfOverwritingEdgeIncorrectly(arithmetic underflow/overflow panic near anaddressfuzz input close totype(uint160).max). This branch makes zero changes underpackages/contracts(verified withgit diff origin/main...HEAD --stat -- packages/contracts, empty). Reproduced the same failure directly onorigin/mainin a clean worktree (2 of 5 fresh-cache runs failed with the same panic, different fuzz seed each time) — confirmed pre-existing, seed-dependent flake in the test/contract logic, unrelated to these dependency bumps. Left untouched per "never weaken tests."DO NOT MERGE — for review only.