Repository navigation
Conversation
- GROUP BY keys normalize -0.0 to 0.0 so both zeros share one group - ORDER BY comparison collapses signed zeros, matching the documented total order - add maxBufferedRows (default 100000) so ordered queries fail instead of buffering unlimited rows - update en/zh_CN/zh_TW docs and add regression tests
- Bound materialized groups for GROUP BY ... ORDER BY by maxBufferedRows, and cover the gap with a regression test that previously returned rows silently. - Report fractional or out-of-range integer literals as "not representable as <type>" instead of wrapping them in "invalid SELECT syntax"; drop the now unreachable Double/DECIMAL literal branches and assert the message in tests. - Normalize signed zeros for grouped float columns so the displayed sign does not depend on scan order; reject ORDER BY references to another table. - Sample the sort deadline (first comparison, then every 1024) instead of reading the clock on every comparison, and stop pinning the tick count. - Cache execute-override detection per class, ignore private/bridge methods, and fail with a clear error when the legacy overload delegates back instead of overflowing the stack. - Keep the deprecated SqlExecuteCommandFunction path on the streaming path so queryTimeoutSeconds is no longer silently dropped. - Compile production code with <release>8</release> (testRelease 11) so Java 9+ APIs fail at build time. - Document the MySQL streaming timeout scope, ordered aggregate buffering and integer literal rules in all three languages; fix the stale "write only" limitation and the incomplete zh_CN timeout range; move PaimonService construction inside the integration test's try block.
AI PR Review — ✅ 可通行
最终总结最终评审结论评审覆盖情况
由于 claudecli 的 part 1 缺失，part 1 只有单一评审覆盖，因此我独立核对了这一片的代码并做了构建/测试验证，而不是直接采信 codexcli 的 PASS：
处置说明
下一步：无阻塞项，可以合并。若要收尾，唯一可选动作是把 zh_CN 表格默认值补上“（对新建查询）”，属可选跟进，不需要在本 PR 阻塞。 FINAL_VERDICT: PASS ===FINDINGS=== codexcli (part 1/2) reviewNo actionable defects found in part 1. I reviewed the changed files and hunks; no tests were run. VERDICT: PASS codexcli (part 2/2) reviewNo actionable defects found in part 2’s documentation, configuration schema, or tests. VERDICT: PASS claudecli (part 2/2) reviewI reviewed every hunk in part 2: the Paimon docs in en_US, zh_CN and zh_TW,
One minor wording gap, which doesn't block: in the zh_CN parameter table the VERDICT: PASS reasonix review最终评审结论评审覆盖情况
由于 claudecli 的 part 1 缺失，part 1 只有单一评审覆盖，因此我独立核对了这一片的代码并做了构建/测试验证，而不是直接采信 codexcli 的 PASS：
处置说明
下一步：无阻塞项，可以合并。若要收尾，唯一可选动作是把 zh_CN 表格默认值补上“（对新建查询）”，属可选跟进，不需要在本 PR 阻塞。 FINAL_VERDICT: PASS ===FINDINGS=== 标记：✅ 可通行 |
AI PR Review — ✅ 可通行
最终总结本轮评审总结增量范围确认（ 历史发现状态：上一轮评审（head 代码核验（我自己在 checkout 中执行，而非仅采信 reviewer）：
评审者一致性：codexcli 与 claudecli 两位独立 reviewer 均给出 PASS，结论与我的代码核验一致，无分歧需调和；无人类新评论待回应。 P2 豁免说明：本轮无任何 reviewer 上报 P2，无需豁免。P0/P1 复核：无 reviewer 提出高severity 主张，故无可驳回或需阻塞项。 唯一待外部确认项（非阻塞）：重命名是否真正清除 Sonar 质量门禁告警，需等本次 CI 扫描结果；这属于流水线验证，不构成本 PR 的代码缺陷。 下一步：无需修复动作。合并前仅需等 CI 扫描确认 Quality Gate 通过即可。 FINAL_VERDICT: PASS ===FINDINGS=== codexcli reviewNo historical findings to re-verify. The incremental diff only renames the private helper and updates its call site; both references match. No human comments were provided. VERDICT: PASS claudecli reviewI found no defects in this round. There were no earlier findings to re-check and no new human comments to answer. This round's diff, from
I didn't compile the code or run tests; this was a read-only review. VERDICT: PASS reasonix review本轮评审总结增量范围确认（ 历史发现状态：上一轮评审（head 代码核验（我自己在 checkout 中执行，而非仅采信 reviewer）：
评审者一致性：codexcli 与 claudecli 两位独立 reviewer 均给出 PASS，结论与我的代码核验一致，无分歧需调和；无人类新评论待回应。 P2 豁免说明：本轮无任何 reviewer 上报 P2，无需豁免。P0/P1 复核：无 reviewer 提出高severity 主张，故无可驳回或需阻塞项。 唯一待外部确认项（非阻塞）：重命名是否真正清除 Sonar 质量门禁告警，需等本次 CI 扫描结果；这属于流水线验证，不构成本 PR 的代码缺陷。 下一步：无需修复动作。合并前仅需等 CI 扫描确认 Quality Gate 通过即可。 FINAL_VERDICT: PASS ===FINDINGS=== 标记：✅ 可通行 |
SonarQube quality gate on TAP-12846-query-timeout fails on new_maintainability_rating (actual D/4.0, required A), 17 code smells / 79min technical debt, all in MysqlConnector.java: - java:S1161 (x9): add @OverRide to methods that override CommonDbConnector (batchReadWithoutHashSplit, clearTable, dropTable, createConstraint, makeTapIndex, getCreateIndexSql, getAfterUniqueAutoIncrementFields, call, getOutputFromCall). - java:S5411 (x6): replace boxed Boolean conditions with Boolean.TRUE.equals (oldVersionTimezone x2, highPerformance x3, createAutoInc). - java:S1155 (x2): use isEmpty() instead of size() >= 1. No behaviour change intended.
AI PR Review — ✅ 可通行
最终总结最终评审结论评审覆盖情况
历史发现状态：上一轮（head 本轮增量（仅
P0/P1：两位评审均无高/严重发现，我复核后也确认增量无高危输入（无并发、无公共 API 签名变更、无构建/JDK 兼容性影响），无需要驳回的误报。P2：无单一评审上报的 P2，故无豁免事项。 下一步：无需代码改动。合并前仅剩 CI 的 Sonar Quality Gate 复核（本轮提交的目的即清零 New Code 债务 FINAL_VERDICT: PASS ===FINDINGS=== codexcli review本轮增量只改动了 VERDICT: PASS claudecli reviewI found no defects in this round. There were no earlier findings to re-check and no new human comments to answer. I reviewed the incremental diff
Nothing here affects concurrency, the public API, the build or JDK compatibility. The PR doesn't add tests for these lines, which is acceptable because they don't change behavior for valid configurations. This was a read-only review: I didn't compile the code or run tests. VERDICT: PASS reasonix review最终评审结论评审覆盖情况
历史发现状态：上一轮（head 本轮增量（仅
P0/P1：两位评审均无高/严重发现，我复核后也确认增量无高危输入（无并发、无公共 API 签名变更、无构建/JDK 兼容性影响），无需要驳回的误报。P2：无单一评审上报的 P2，故无豁免事项。 下一步：无需代码改动。合并前仅剩 CI 的 Sonar Quality Gate 复核（本轮提交的目的即清零 New Code 债务 FINAL_VERDICT: PASS ===FINDINGS=== 标记：✅ 可通行 |
…ctors - csv-connector: enable jacoco prepare-agent/report like the other connector modules. Without the agent SonarQube recorded 0% coverage for every csv file (CsvConnector 217/217 and CsvValueConverter 166/166 uncovered). - CsvValueConverterTest: assert wall-clock DATETIME parsing for both the determineDateFormat and FLEXIBLE_DATETIME paths (New Code lines 184/206). - MysqlConnectorTest: add NewCodeCoverageTest covering clearTable, dropTable, getAfterUniqueAutoIncrementFields, call, streamRead, streamReadMultiConnection and both timestampToStreamOffset branches.
AI PR Review — ✅ 可通行
最终总结最终评审结论评审范围：增量 历史发现状态：上一轮（head 本轮我独立复核的结论
一致性与 P2 豁免：两位独立评审（codexcli、claudecli）均为 PASS，无高/中危发现，也就不存在单一评审上报的 P2 需要豁免或独立证实。我复核后同样没有发现新增缺陷：本轮改动不触碰生产逻辑、公共 API、并发或 JDK 兼容性，故无 P0/P1 可驳回项，也没有需要保留的 P2。 下一步：无需代码改动。剩余唯一动作是等 FINAL_VERDICT: PASS ===FINDINGS=== codexcli reviewNo historical findings were recorded in the previous review. I found no actionable defects in the three files changed since that review. The JaCoCo executions match the connector’s existing setup, and the added tests introduce no apparent compatibility or correctness issue. I did not run tests; this was a read-only review. VERDICT: PASS claudecli reviewI found no defects in this round. The previous review had no findings to re-check, and there are no new human comments to answer. This round (
I didn't compile the code or run the tests. Reasonix's earlier local run says the tests pass, but I haven't confirmed it. Whether new-code coverage now clears the Sonar Quality Gate is still waiting on the next CI scan. VERDICT: PASS reasonix review最终评审结论评审范围：增量 历史发现状态：上一轮（head 本轮我独立复核的结论
一致性与 P2 豁免：两位独立评审（codexcli、claudecli）均为 PASS，无高/中危发现，也就不存在单一评审上报的 P2 需要豁免或独立证实。我复核后同样没有发现新增缺陷：本轮改动不触碰生产逻辑、公共 API、并发或 JDK 兼容性，故无 P0/P1 可驳回项，也没有需要保留的 P2。 下一步：无需代码改动。剩余唯一动作是等 FINAL_VERDICT: PASS ===FINDINGS=== 标记：✅ 可通行 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AI PR Review — ✅ 可通行
最终总结我先自己核对这次增量 diff 与相关代码，再下结论。 最终评审结论本轮范围： 评审覆盖与一致性
上轮历史发现状态：上一轮（head 我的独立核对（不依赖两位评审的结论）
未采纳的低价值项（抑制，不进入 FINDINGS）： 需要做什么：无需修复，可以合并。唯一建议是留一次真实 MySQL + 自定义 SQL 别名的联调（含 FINAL_VERDICT: PASS ===FINDINGS=== codexcli review本轮只检查了
VERDICT: PASS claudecli reviewI found no defects in this round. There were no earlier findings to re-check, and there are no new human comments to answer. Scope: the incremental range What I checked in the change:
I didn't run any tests; this was a read-only review. VERDICT: PASS reasonix review我先自己核对这次增量 diff 与相关代码，再下结论。 最终评审结论本轮范围： 评审覆盖与一致性
上轮历史发现状态：上一轮（head 我的独立核对（不依赖两位评审的结论）
未采纳的低价值项（抑制，不进入 FINDINGS）： 需要做什么：无需修复，可以合并。唯一建议是留一次真实 MySQL + 自定义 SQL 别名的联调（含 FINAL_VERDICT: PASS ===FINDINGS=== 标记：✅ 可通行 |
No description provided.