Repository navigation
fix(TAP-12896): do not treat 0/0 as snapshot complete on sync nodes - #634
Merged
Merged
Conversation
Queued child tables report tableTotal=0 and snapshotTableTotal=0. The previous equality check drew a full progress bar before snapshot started. Require tableTotal > 0 before marking 100%.
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snapshotTableTotal === tableTotalto mark 100%.0/0before snapshot starts, so the bar was drawn full.tableTotal > 0before treating the node as snapshot complete. Migrate already usedtableTotal ? percent : 0.Jira: https://tapdata.atlassian.net/browse/TAP-12896
TM companion: tapdata
fix-TAP-12896-develop(unsetnodeCurrentEventTimestampon reset).Test Plan
tableTotal > 0and counts match), progress is still 100%.