Repository navigation
feat: run predefined menu items from a menu snapshot - #418
Merged
Merged
Conversation
Add `PredefinedMenuItemSnapshot::activate`, so a snapshot shown from another thread or process can run what its menu items do: the about dialog, the edit commands, and on GTK 4 the window items. It is queued on the platform's main thread like the other snapshot callbacks.
`PredefinedMenuItemType` holds an optional `AboutMetadata` whose icon is `Send` but not `Sync` on Windows, so capturing it in the `activate` closure made the closure non-`Sync` and failed to build. Read it from the shared state when the item is activated instead.
amrbashir
force-pushed
the
amr/feat/snapshot-predefeined
branch
from
September 25, 2026 00:57
09e94f0 to
38158b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
PredefinedMenuItemSnapshot::activate, so a snapshot shown from another thread or process can run what its menu items do: the about dialog, the edit commands, and on GTK 4 the window items. It is queued on the platform's main thread like the other snapshot callbacks.