fix(profiles): show each profile's bundle id in the unfiltered list - #26
Conversation
profiles list without --bundle-id-id returned bundleIdId "" for every profile: the mapper reads the bundle ID from relationship data, which Apple only sends when the request asks for it with include=bundleId. Verified live: 6/6 profiles now carry their bundle ID, and each matches the profiles returned by --bundle-id-id for that bundle. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughWhen ChangesProfile listing
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Unfiltered profile listings now request bundle-ID relationship data, addressing the reported empty bundle IDs. No actionable merge-blocking risk is evident, so the change is ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 81.75% 81.85% +0.09%
==========================================
Files 473 473
Lines 13862 13864 +2
==========================================
+ Hits 11333 11348 +15
+ Misses 2529 2516 -13
🚀 New features to boost your workflow:
|
Stacked on #25, since both change the same
listProfilescall. Merge order: #23, then #24, then #25, then this one.Problem
asc profiles listwithout--bundle-id-idreturnedbundleIdId: ""for every profile. That also broke itslistProfilesaffordance, which rendered asasc profiles list --bundle-id-idwith no value. The mapper reads the bundle ID from relationship data, and Apple only sends that data when the request asks for it withinclude=bundleId. The existing unit-test fixture included the data anyway, so the tests passed.Fix
GET /v1/profilesnow passesinclude: [.bundleID].Tests
include=bundleId. It failed before the fix.swift testpasses.Live check (read-only)
--bundle-id-id <id>returns the same profiles.GET /v1/profilesleaves out Xcode-managed "Team" profiles, while the per-bundle endpoint includes them. That's Apple's behaviour and unchanged here.🤖 Generated with Claude Code
Summary by CodeRabbit
profiles listnow includes bundle IDs in profile records when no bundle ID filter is supplied.