Repository navigation
Skip PowerShell-dependent setup when pwsh is unavailable - #17
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dotfiles installer runs with
set -eand invokes the PowerShell-basedlogfmtpp downloader before VS Code extension installation. On machines without
pwsh, that step fails and prevents the remaining setup from running.Changes
pwshis available before setting up the PowerShell profile andinstalling logfmtpp.
VS Code extension setup.
PowerShell is available.
Validation
bash -n install.shshellcheck -e SC1091 install.sh(checks the changed installer without followingsourced scripts)
git diff --checkpwsh: both dependent steps are skipped and VS Code setup runs.pwsh: all steps run in their existing order.pwshis available.
The full installer was not rerun against the current machine; the fixtures
stubbed installation steps and used a temporary home directory.