fix(sql-editor): harden Server Beam MAX_SQL (all bridge calls) - #160
Open
huyplb wants to merge 2 commits into
Open
fix(sql-editor): harden Server Beam MAX_SQL (all bridge calls)#160huyplb wants to merge 2 commits into
huyplb wants to merge 2 commits into
Conversation
Plain sql`` under Beam no longer bypasses the cap. Bridge calls are queued so Promise.all cannot race the counter. Adds createBeamSqlCap helpers and coverage for sequential, mixed, and concurrent limits. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_43e688b3-7808-476a-91e0-75515bc4ba0b) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two Medium findings from the Server Beam review:
sql\…`under Beam no longer skipsMAX_SQL(onlysql.on` used to count).Promise.allcannot race the counter; queries run one at a time under Beam.Tests added
createBeamSqlCapunit tests (hard max + interleaved microtasks)sqlcounts toward the cap (mixed withsql.on)Promise.allofMAX_SQL + 5→ exactlyMAX_SQLfulfilled, 5 rejected; max in-flight = 1MAX_SQLsequential calls still succeedsAPI / copy
Error text:
Server Beam allows at most N SQL bridge calls per editor Execute