Repository navigation
Meeting Notes from the calendar - #72
Merged
Merged
Conversation
[[calendars]] in the user config (name, url, optional color) lists ICS feeds; entries missing a name or url are reported and skipped, and the Vault config refuses them since feed URLs are secrets. spc m / :meetings fetches every feed concurrently (15 s timeout each) and lists Today's timed Meetings, sorted by start, with the calendar name as Detail. All-day Meetings are left out; a failing feed shows one info line and fails alone. The new internal/calendar package parses (golang-ical) and fetches; recurrence and VTIMEZONE-only TZIDs come in later tickets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
enter on a Meeting creates its Meeting Note from meeting_template (or a built-in Template) in meetings_folder, with a meeting_uid: frontmatter line, and opens it on its last line. A Meeting that already has a Meeting Note shows a check in the gutter and enter re-opens it. daily.Render takes extra time and text placeholders for the Meeting ones. meetings_folder and meeting_template are Vault keys in config init. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Parse keeps a recurring Meeting as one series; On expands it with rrule-go into the day's occurrences (RRULE, RDATE, EXDATE, and RECURRENCE-ID overrides). Meeting.Original is the occurrence's original start in UTC, so a moved occurrence keeps its identity. A TZID resolves through Go's tz database, then Windows names, then the feed's own VTIMEZONE (offset in force at the occurrence), else local time; no Meeting is skipped for its timezone. End falls back to DTSTART + DURATION. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- config.Dirs gains CacheHome ($XDG_CACHE_HOME, else ~/.cache). - calendar.Fetch takes a cache dir: a body that parses replaces <cache>/pholio/calendars/<sha256(url) prefix>.ics (mode 0600, mtime is the fetch time); a bad body leaves it alone. calendar.Cached reads it. - Init fetches every feed in the background. The picker shows what is known at once, refetches feeds older than 15 min on open, and r refetches all. Failing calendars get a status line: the fetch error, or "offline, showing data from 2h ago" when cached data is shown. Loading… only shows while fetching with no data at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rs (#70) h/l and left/right move between days, t returns to Today; the title shows the day with (today)/(yesterday)/(tomorrow). Meetings that have ended are drawn in overlay.hint. The calendar name takes the calendar's colour: [[calendars]] color, else the feed's calendar-level COLOR:, else overlay.hint. A bad configured colour is a config problem. palette.Item gains DetailColor (a raw colour) and palette.WithTitle; theme.ParseCSSColor reads CSS names (golang.org/x/image/colornames) and #rrggbb; calendar.Meeting gains CalendarColor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # internal/app/meetings.go
A moved occurrence (RECURRENCE-ID) keeps its Meeting Note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
calendar.Meeting gains Attendees, Location, Link and Description, read in the new internal/calendar/details.go; meetingNoteText renders them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # internal/app/meetings.go
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Creating a Meeting Note appends '- HH:mm [[name]]' under meetings_heading (new Vault key, default '## Meetings', in config init) in the Meeting's Daily Note, adding the heading when missing. Without that Daily Note the back-link is skipped and the status says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # internal/app/meetings.go
Conflicts in internal/calendar: kept both sides. Meeting has #71's details fields and #68's Original/series; Parse extracts details on every event (series masters and overrides) before the series/override handling, so On's occurrence copies carry them. Cached goes through parseFeed -> Parse, and the app reads occurrences via On. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # internal/calendar/calendar.go
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # go.mod # internal/calendar/calendar.go
…ackground Every network failure other than a timeout is now "offline", so a feed's secret URL never reaches the picker. Startup fetches every feed whatever its cache's age, staleness on opening the picker counts from the last successful fetch (so a failed feed is retried), and the cache is read in a tea.Cmd instead of on the UI thread. Dedupe the RRULE build and name the DATE-TIME layout once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Meeting Notes are found anywhere under meetings_folder. A new Meeting Note is written with an exclusive create (seam.FS gains Create), counting up past a file that appeared after the name was chosen. A CRLF meeting Template's frontmatter gets the meeting_uid: line instead of a second block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #64 (Meeting Notes from the calendar), tickets #65–#71.
Summary
Evidence
spc munbound.After:
go test -race ./...green, golangci-lint 0 issues. Tests written red-first include:TestAMovedOccurrenceKeepsItsMeetingNote: RECURRENCE-ID moves an occurrence → same Meeting Note opensTestFetchNeverReportsTheSecretURL: closed server at a secret URL → info line saysoffline, no URLTestANoteAppearingWhileAskedIsNotOverwritten: file appears during the save prompt → Note goes to-2TestStartupFetchesEvenAFreshCache,TestOpeningRetriesAFailedFetch,TestAMeetingNoteInASubfolderIsFound,TestACRLFTemplateFrontmatterGetsTheMeetingUID.icscoverage: BYDAY ordinals, BYSETPOS, comma EXDATE, Windows TZID,Customized Time ZoneVTIMEZONE, unresolvable TZID, all-day, DURATION; httptest for 401 / timeout / non-ICS / cache not replaced.Merge Danger
Door: two-way
Additive feature; nothing changes unless
[[calendars]]is configured. Revert is clean.Blast Radius: moderate
seam.FSgainsCreate, andopenThen'sbeforecallback now returns the path to open (openDailyadapted).tasks.AddAt/AddFilerefactored ontoSectionAt/EditFile; behaviour unchanged, covered by existing tests.arran4/golang-ical,teambition/rrule-go,golang.org/x/image(CSS colour names);golang.org/x/sys0.47 → 0.49.ponytail:comment);RANGE=THISANDFUTUREnot handled.🤖 Generated with Claude Code