Conversation
Co-authored-by: arokem <118582+arokem@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 88.66% 88.66%
=======================================
Files 15 15
Lines 7765 7765
Branches 1044 1044
=======================================
Hits 6885 6885
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: arokem <118582+arokem@users.noreply.github.com>
|
@frheault : why did you close this? It does fix the mac issue, and maybe with some more work could also fix the Windows issue? |
|
OIC, looks like you are mitigating this in #49 |
|
@arokem I thought the copilot suggestion would be shown to me and then I could test it on my PR rather than a separate PR and I didn't like the idea of doing iterative PR, then merging with my PR and then realize it was not working so I closed it and transfert the solution. (So this was more ''in case'' to avoid multiple PR if it did not work on first try) |
|
Yes - no worries - this all makes sense and I think we are all good now! |
The
consumer macos-latestjob failed because CMake installed trx-cpp to unwritable/usr/local. The consumer build now uses a workspace-local install prefix.Local installation
${GITHUB_WORKSPACE}/installasCMAKE_INSTALL_PREFIX.Consumer discovery
CMAKE_PREFIX_PATHat the same local prefix.