You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TempoTransaction.from_dict accepts camelCase keys (chainId, maxFeePerGas, gas, value, ...), which is the Ethereum JSON-RPC convention — where quantities are hex strings (e.g. "0x64"). But it passed those values through unconverted, so parsing a standard JSON-RPC transaction dict raised TypeError: '<' not supported between instances of 'str' and 'int' during validate().
This coerces quantity fields (chain_id, max_fee_per_gas, max_priority_fee_per_gas, gas_limit, nonce, nonce_key, valid_before, valid_after, and per-call value) via a small as_int helper that accepts hex strings, decimal strings, and ints. Integer and snake_case inputs are unaffected. Adds tests for both hex-string and int inputs.
Friendly ping on this one — it fixes a real bug: TempoTransaction.from_dict raises TypeError on JSON-RPC-style dicts with hex-string quantities (e.g. {"chainId": "0xa5bd", "value": "0x64"}), which is the standard Ethereum encoding implied by the camelCase keys it already accepts. The fix coerces the quantity fields via a small as_int helper; integer/decimal inputs are unaffected, and it adds tests for both. It's a fork PR so the Actions workflows need a maintainer to approve the run. Happy to rebase or adjust anything needed.
Thanks for merging #90 and #91! This one is the same class of small correctness fix — TempoTransaction.from_dict raises TypeError on JSON-RPC-style dicts with hex-string quantities (e.g. {"chainId": "0xa5bd", ...}), even though from_dict advertises camelCase/JSON-RPC keys. It's green and mergeable — would be great to land it alongside the others if it looks good. Thanks!
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TempoTransaction.from_dictaccepts camelCase keys (chainId,maxFeePerGas,gas,value, ...), which is the Ethereum JSON-RPC convention — where quantities are hex strings (e.g."0x64"). But it passed those values through unconverted, so parsing a standard JSON-RPC transaction dict raisedTypeError: '<' not supported between instances of 'str' and 'int'duringvalidate().This coerces quantity fields (
chain_id,max_fee_per_gas,max_priority_fee_per_gas,gas_limit,nonce,nonce_key,valid_before,valid_after, and per-callvalue) via a smallas_inthelper that accepts hex strings, decimal strings, and ints. Integer and snake_case inputs are unaffected. Adds tests for both hex-string and int inputs.