Conversation
StablecoinDEX exposed swap and order call builders but no way to quote a swap or convert between order ticks and prices. Add quote_swap_exact_amount_in, quote_swap_exact_amount_out, tick_to_price, and price_to_tick read helpers (mirroring the existing storage_credits helper) so callers can price swaps and orders without sending a transaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StablecoinDEXexposes call builders for swaps and orders (swap_exact_amount_in,place,cancel, ...) but no way to quote a swap or convert between order ticks and prices, so callers had to send a transaction to discover pricing.Add four read helpers, mirroring the existing
storage_creditshelper:quote_swap_exact_amount_in/quote_swap_exact_amount_out— quote a swap's output/input without executing ittick_to_price/price_to_tick— convert between an order tick and its price (price_to_tickdecodes the signedint16result)Each helper reuses the shipped
IStablecoinDEXABI and the existing decode helpers. Includes tests (encoded selector + decoded value for each, plus a negative-tick case forprice_to_tick) and a changelog entry.