Skip to content

Fortified rfft #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
veblush wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fortified rfft #3686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abf7535
Fortified rfft
veblush Sep 1, 2026
cf9a5fb
Reformat
veblush Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions signal/micro/kernels/fft_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,4 +500,20 @@ TEST(FftTest, FftAutoScaleTestLarge) {
nullptr, 0, output, &scale_bit));
}

TEST(FftTest, RfftInputLengthGreaterThanFftLengthFails) {
constexpr int kOutputLen = 66;
int input_shape[] = {1, 128};
float input[128] = {0};
int output_shape[] = {1, kOutputLen};
float golden[kOutputLen] = {0};
float output[kOutputLen];
const TFLMRegistration* registration =
tflite::tflm_signal::Register_RFFT_FLOAT();
EXPECT_EQ(kTfLiteError,
tflite::testing::TestFFT<float>(
input_shape, input, output_shape, golden, *registration,
g_gen_data_fft_length_64_float,
g_gen_data_size_fft_length_64_float, output, 1e-7));
}

TF_LITE_MICRO_TESTS_MAIN
2 changes: 2 additions & 0 deletions signal/micro/kernels/rfft.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ TfLiteStatus RfftPrepare(TfLiteContext* context, TfLiteNode* node) {
params->output_length =
output_shape.Dims(output_shape.DimensionsCount() - 1) / 2;

TF_LITE_ENSURE(context, params->input_length <= params->fft_length);

context->RequestScratchBufferInArena(context, params->fft_length * sizeof(T),
&params->scratch_buffer_index);
micro_context->DeallocateTempTfLiteTensor(input);
Expand Down
Loading