Application custom DECODE operator support (part 1) - #3687
Open
ddavis-2015 wants to merge 10 commits into
Open
ddavis-2015 wants to merge 10 commits into
ddavis-2015 wants to merge 10 commits into
Conversation
@tensorflow/micro This is part 1 of 2 to add support for custom DECODE operators and their registration. Part 2 will add this support to the Python MicroInterpreter wrapper. Add unit tests for custom DECODE operator registration. Re-enable -Werror in the Makefile. Fix minor comment typos. bug=fixes tensorflow#3215
ddavis-2015
added
the
ci:full
@tensorflow/micro Put the -Werror flag back into the primary makefile, to prevent creaping warning accumulation. Fix various warning generators in codebase. bug=fixes tensorflow#3689
veblush
reviewed
Sep 15, 2026
|
|
||
| struct CustomDecodeRegistration { | ||
| tflite::DecodeState* (*create_state)(const CustomDecodeRegistration&, | ||
| const TfLiteContext&, |
Collaborator
There was a problem hiding this comment.
Curious whether usage of & is intentional? TFLM used to use * for those types like TfLiteContext*.
veblush
reviewed
Sep 15, 2026
| const CustomDecodeRegistration* registrations, size_t count); | ||
|
|
||
| // Get the custom decompression registrations. | ||
| virtual const std::pair<const CustomDecodeRegistration*, size_t /*count*/> |
Collaborator
There was a problem hiding this comment.
nit: just std::pair would be better than const std::pair as a return value type.
veblush
reviewed
Sep 15, 2026
| // Set the DECODE operator custom registrations. | ||
| // Can only be called during the MicroInterpreter kInit state (i.e. must | ||
| // be called before MicroInterpreter::AllocateTensors). | ||
| // The regions pointer argument is the start of a |
Collaborator
There was a problem hiding this comment.
registrations pointer instead?
veblush
reviewed
Sep 15, 2026
veblush
left a comment
veblush
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with a few minor comments
Remove virtual specifiers where not needed.
ddavis-2015
had a problem deploying
to
integration-test
September 29, 2026 01:06 — with 
GitHub Actions
Error
GitHub Actions
Error
veblush
previously approved these changes
Sep 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 29, 2026
Member
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tensorflow/micro
This is part 1 of 2 to add support for custom DECODE operators and their registration. Part 2 will add this support to the Python MicroInterpreter wrapper.
Add unit tests for custom DECODE operator registration.
Fix minor comment typos.
bug=fixes #3215