Conversation
kortemik
requested review from
51-code and
eemhu
and removed request for
eemhu
September 11, 2024 10:00
51-code
suggested changes
Sep 11, 2024
51-code
left a comment
51-code
left a comment
There was a problem hiding this comment.
Didn't nitpick too much as it's a draft. Some general comments here:
- The new classes could all be made final.
- Encodable, Clock, PriorityCloseClock, PriorityNumbersClock and PriorityOpenClock are missing a license.
- Multiple FIXME and TODO comments, but the PR is a draft so they are most likely fine to have at this point.
I had trouble understanding the Clock classes. Maybe it's the naming that's throwing me off?
…orityNumbersClock to NumberClock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.