Skip to content

feat(mssql_server)!: update default image to SQL Server 2025 - #502

Open
saurabh500 wants to merge 1 commit into
testcontainers:mainfrom
saurabh500:dev/saurabh/repository-and-tiberius
Open

saurabh500 wants to merge 1 commit into
testcontainers:mainfrom
saurabh500:dev/saurabh/repository-and-tiberius

Conversation

@saurabh500

@saurabh500 saurabh500 commented Sep 13, 2026 •

Copy link
Copy Markdown

Summary

  • Update the default Microsoft SQL Server image from 2022-CU14-ubuntu-22.04 to the pinned 2025-CU8-GDR1-ubuntu-22.04 release.
  • Preserve the Ubuntu 22.04 base, Developer edition, authentication settings, EULA opt-in, and readiness conditions.
  • Document the new default and the existing ImageExt::with_tag override.

Compatibility

This changes the default SQL Server major version from 2022 to 2025. Applications that need SQL Server 2022 can continue using .with_tag("2022-CU14-ubuntu-22.04").

Validation

  • Confirmed the tag and manifest in Microsoft Container Registry: Linux/amd64, Ubuntu 22.04, SQL Server 17.0.4085.5.
  • Started the pinned image with the module's default settings, observed both existing readiness messages, authenticated as sa, verified major version 17, and confirmed SELECT 1 + 1 returns 2. Removed the smoke-test container afterward.
  • cargo fmt --all -- --check passed, with warnings about nightly-only formatting options.
  • cargo +1.95 check --lib --features mssql_server passed.
  • cargo +1.95 doc --no-deps --features mssql_server passed, with the existing unrelated with_sa_password link warning.
  • cargo +1.95 test --lib --features mssql_server mssql_server::tests -- --nocapture was blocked before test execution by the unrelated rdkafka-sys development dependency: its Windows build could not find the cp executable. The direct container smoke test above passed; the repository's Tiberius integration tests still need to run in Linux CI.

Use the pinned 2025-CU8-GDR1-ubuntu-22.04 image and document how to override the default tag.

BREAKING CHANGE: MssqlServer now defaults to SQL Server 2025 instead of SQL Server 2022.
@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 57a8149c-e8ba-4128-8fee-6b8efe27851f

📥 Commits

Reviewing files that changed from the base of the PR and between d69e3a0 and 09f91ae.

📒 Files selected for processing (1)
  • src/mssql_server/mod.rs

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Summary by CodeRabbit

  • Changes

    • SQL Server containers now use SQL Server 2025 by default on Ubuntu 22.04 instead of SQL Server 2022.
    • The default image tag can still be overridden when a different version is needed.
  • Documentation

    • Added guidance describing the default SQL Server version and how to customize the image tag.

Walkthrough

The MSSQL Server module now uses SQL Server 2025 by default on Ubuntu 22.04. Its documentation states that callers can override the image tag with ImageExt::with_tag.

Changes

MSSQL Server image update

Layer / File(s) Summary
Update the default SQL Server image
src/mssql_server/mod.rs
The default image tag changes to 2025-CU8-GDR1-ubuntu-22.04. Module documentation describes the default image and the ImageExt::with_tag override.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 09f91

The documented SQL Server image upgrade is validated and provides an override for applications requiring SQL Server 2022.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the primary change: updating the default SQL Server image to SQL Server 2025. It is concise and appropriately marks the change as breaking.
Description check ✅ Passed The description directly explains the image update, compatibility impact, documentation changes, and validation results.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the image tag,
SQL Server hops to twenty-five.
Ubuntu keeps the burrow warm,
While with_tag lets choices thrive.
The module notes the path,
And the carrot build survives.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant