feat(mssql_server)!: update default image to SQL Server 2025 - #502
saurabh500 wants to merge 1 commit into
Conversation
Use the pinned 2025-CU8-GDR1-ubuntu-22.04 image and document how to override the default tag. BREAKING CHANGE: MssqlServer now defaults to SQL Server 2025 instead of SQL Server 2022.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. Summary by CodeRabbit
WalkthroughThe MSSQL Server module now uses SQL Server 2025 by default on Ubuntu 22.04. Its documentation states that callers can override the image tag with ChangesMSSQL Server image update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The documented SQL Server image upgrade is validated and provides an override for applications requiring SQL Server 2022. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the image tag, Comment |
Summary
2022-CU14-ubuntu-22.04to the pinned2025-CU8-GDR1-ubuntu-22.04release.ImageExt::with_tagoverride.Compatibility
This changes the default SQL Server major version from 2022 to 2025. Applications that need SQL Server 2022 can continue using
.with_tag("2022-CU14-ubuntu-22.04").Validation
17.0.4085.5.sa, verified major version17, and confirmedSELECT 1 + 1returns2. Removed the smoke-test container afterward.cargo fmt --all -- --checkpassed, with warnings about nightly-only formatting options.cargo +1.95 check --lib --features mssql_serverpassed.cargo +1.95 doc --no-deps --features mssql_serverpassed, with the existing unrelatedwith_sa_passwordlink warning.cargo +1.95 test --lib --features mssql_server mssql_server::tests -- --nocapturewas blocked before test execution by the unrelatedrdkafka-sysdevelopment dependency: its Windows build could not find thecpexecutable. The direct container smoke test above passed; the repository's Tiberius integration tests still need to run in Linux CI.