fix: prevent NVM POSIX class pattern panic - #100
Open
roeyazroel wants to merge 1 commit into
Open
Conversation
roeyazroel
marked this pull request as ready for review
August 9, 2026 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mvdan.cc/sh/v3to an immutablev3.13.1-based fork commit containing the mixed POSIX character-class parser fix*[![:space:]]*alias patternpattern/pattern.goand its testsRoot cause
NVM 0.40.6 uses
*[![:space:]]*while reading aliases.mvdan/shstopped the outer bracket expression at the inner POSIX-class], producing the invalid Go regexp(?s)^.*[^[:space:]\].*$. The interpreter passes successful pattern translations toregexp.MustCompile, sonvm use --ltspanicked the entire Hash process.The fork fixes POSIX classes as elements within larger bracket expressions and hardens filename-mode scanning around nested classes, escapes, slash literalization, malformed constructs, and unclosed brackets.
Upstream fix: mvdan/sh#1374
The
replaceis temporary and should be removed once an officialmvdan/shrelease includes that PR.Validation
go test ./internal/executor -run '^TestShellPattern_NegatedPOSIXClassCompiles$' -count=1go test ./internal/compat ./internal/executor ./internal/shell— 501 testsgo test ./...— 1,887 tests across 24 packagesnvm use --ltsselected Nodev24.19.0; subsequentnode --versionreturnedv24.19.0; no panicgit diff --check