Allow Saloon ^3.0 || ^4.0 - #28
Merged
Merged
Conversation
QdrantConnector is a stock Connector (HasTimeout + HeaderAuthenticator). Asgard is locked to Saloon v3 via the-shit/finance.
![lexi-chief-of-staff[bot]](https://avatars.githubusercontent.com/in/3490641?s=60&v=4){kind=small}
There was a problem hiding this comment.
Ship it.
- composer.json change is a pure constraint relaxation to unblock the-shit/finance on Saloon v3.
- QdrantConnector uses only stock traits (HasTimeout + HeaderAuthenticator); no custom Saloon v4 APIs introduced.
- Matches the explicit goal in the PR body and the linked Asgard#148.
- No other files or tests impacted; risk is isolated to dependency resolution.
CI fetches master OpenAPI; nearest-neighbor search now lives on POST /points/query. Keep the Saloon ^3 || ^4 constraint.
Contributor
Author
|
CI green on 8.3 and 8.4. The red run was OpenAPI contract tests against live Qdrant master: `POST /points/search` was retired; nearest-neighbor is `POST /points/query`. Saloon `^3.0 || ^4.0` constraint unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asgard cannot
composer require the-shit/vectortoday: this package asks for Saloon ^4.0 while Asgard/the-shit/finance is on Saloon v3.QdrantConnectoris a stock Saloon Connector (HasTimeout+HeaderAuthenticator). Constraint only.Refs jordanpartridge/Asgard#148