Skip to content

Preserve approved imports during upstream maintenance - #51

Merged
thecolormaroun merged 3 commits into
mainfrom
codex/maintenance-missing-upstream-review
Nov 13, 2026
Merged

thecolormaroun merged 3 commits into
mainfrom
codex/maintenance-missing-upstream-review

Conversation

@thecolormaroun

@thecolormaroun thecolormaroun commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Restore maintenance materialization when curated David and Matt imports disappear upstream. Apply the owner-approved retention entries for 13 David skill directories, Matt's merge-conflict skill, and Matt's legacy CONTEXT-FORMAT.md at their existing inspected revisions. Existing approved retentions remain intact; no skill is deleted or rebound to a new source.

The materializer also reports absent upstream directories as upstream_deletion_requires_approval and preserves each retained support file's original inspected commit across subsequent provider advances. Legacy Markdown and per-file Markdown/JSON provenance round-trip, including mixed-origin files; malformed records fail closed. A regression validates every curated retained target against its existing source metadata.

Validation: 79 focused tests passed (materializer, runner and upstream packages), metadata/doctor/bootstrap checks and git diff --check passed, and a fresh independent read-only review returned no findings. Direct materialization checks using the exact audited David and Matt commits pass with the approved rules and produce no replacement bytes for retained targets or the legacy support file.

Retention policy was explicitly approved by the owner on November 9, 2026. Merge, runtime installation/publication, vendor restoration, plugin mutation and cleanup remain outside this change's execution authority. Receipt-bound prepare always uses the exact audited main commit; successful PR-branch checks do not establish canonical workflow success before this draft is integrated.

@thecolormaroun thecolormaroun changed the title Classify removed mapped skills for approval Preserve retained import provenance and classify upstream removals Nov 9, 2026
@thecolormaroun thecolormaroun changed the title Preserve retained import provenance and classify upstream removals Preserve approved imports during upstream maintenance Nov 9, 2026
@thecolormaroun
thecolormaroun marked this pull request as ready for review November 13, 2026 17:35
@thecolormaroun
thecolormaroun merged commit 73136f9 into main Nov 13, 2026
3 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T17:36:44.859547Z 04569c3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

thecolormaroun added a commit that referenced this pull request Nov 13, 2026
Adds two new skills from emilkowalski/skills at f8ff3b0a1b6edbad62a6cd7fc0d06ef2a6f7e4ab:
- emil-gestures (design): drag, swipe, and sheet interactions that track the finger and stay interruptible.
- emil-learn-taste (design): turns a user's design corrections into rules in DESIGN.md, a project skill, or a lint check.

The importer bumps the whole Emil pin (c8a7962 -> f8ff3b0). The existing Emil skills
change only in their pinned-commit lines; their upstream content is unchanged.

Counts in docs/skill-architecture.md and README now read 161 capabilities (153 active,
design 33). They also pick up stageshow (#53), which never updated them.

Cut from 73136f9 (after #51), so the materializer keeps review-animations'
retained STANDARDS.md at its original inspected commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant