Repository navigation
fix(pr-scope): fold r.full into run flag per SUITE.md safety rule (#4) - #9
Open
maxx-GENIUS wants to merge 1 commit into
Open
maxx-GENIUS wants to merge 1 commit into
maxx-GENIUS wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4 by ensuring
pr-scope.mjsfoldsr.fullinto therunoutput.Background
Per
SUITE.md(§area_paths), unmapped source changes or a missingarea_pathsdeclaration must trigger the full tier ("An omission in this table therefore costs runner time, never coverage").Previously,
pr-scope.mjscapturedr.fullintowould_have_run_fullbut omitted it fromrun, causing PR checks on products with unmapped changes or pendingarea_pathsto emitrun=falseand silently execute 0 tests.Changes
plugins/claudegrill/scripts/pr-scope.mjsto setrun: areas.length > 0 || specs.length > 0 || Boolean(r.full).node --check.Fixes #4