fix(ombi): make Latte form and filter text readable - #733
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified; remaining feedback is a minor documentation nit.
Pull request overview
This PR improves Ombi Catppuccin Latte readability for filters, profile text, and form fields, with local development and validation documentation.
Changes:
- Improves filter, profile, label, hint, and outline colors.
- Adds a local Ombi/CSS Compose setup.
- Documents setup, testing, and known limitations.
File summaries
| File | Summary |
|---|---|
dev/ombi/README.md |
Documents local development and verification. |
dev/ombi/compose.yaml |
Defines the local Ombi and CSS services. |
css/base/ombi/ombi-base.css |
Applies readability-focused UI styling. |
Review details
Suppressed comments (1)
dev/ombi/README.md:12
- This says the CSS service mounts the whole checkout, but
compose.yamlonly mounts../../css,../../resources, and../serve.pyread-only. Please describe the actual mounted paths so readers do not expect the rest of the checkout to be available in the container.
The CSS server uses http://localhost:18868 and mounts this checkout read-only.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unreadable genre and filter labels, the profile name, and Customization field labels and hints in Catppuccin Latte. Pair the selected filter's text and background colors and make field outlines visible.
Closes #715.
Verified through Ombi's saved Custom CSS setting on 4.53.4 with Chrome 142 and Firefox 155. Chrome checks covered Latte, Nord, Aquamarine, Hotline, hover, selection, field focus, and desktop/mobile layouts. Also checked Customization on stable 4.53.10. Local imports, theme generation, and Compose validation passed.
Development setup is in a separate commit. Remaining poster, sidebar-icon, and redesigned Discover contrast issues are recorded in
dev/ombi/README.md. Native light mode, Safari, disabled fields, and validation-error states were not verified.Screenshots show Ombi 4.53.4 at 1495 × 900. Public poster data changes between captures.