intel: platform: use Kconfig for IDC stack size#11031
Open
serhiy-katsyuba-intel wants to merge 1 commit into
Open
intel: platform: use Kconfig for IDC stack size#11031serhiy-katsyuba-intel wants to merge 1 commit into
serhiy-katsyuba-intel wants to merge 1 commit into
Conversation
The stack size is defined by the Kconfig option CONFIG_SOF_STACK_SIZE. On some platforms, the IDC worker thread stack used a hard-coded value, which seems to have been an oversight. The default CONFIG_SOF_STACK_SIZE value is 4096, but it is increased to 8192 on the PTL board and in some overlays, such as the MTL DAX overlay. Therefore, this change also increases the IDC worker thread stack size for those configurations. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
July 23, 2026 15:13
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns Intel platform stack sizing with the existing Kconfig setting by defining SOF_STACK_SIZE in terms of CONFIG_SOF_STACK_SIZE (instead of a hard-coded 0x1000). This makes the IDC worker thread stack size follow board/overlay configuration (e.g., PTL/MTL DAX overlays increasing it to 8192), matching how multiple other platforms already derive SOF_STACK_SIZE.
Changes:
- Replace hard-coded
SOF_STACK_SIZE(4KB) withCONFIG_SOF_STACK_SIZEon Meteorlake, Lunarlake, and ACE30. - Ensure IDC worker thread stack sizing tracks Kconfig/overlay adjustments for affected Intel targets.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/platform/meteorlake/include/platform/lib/memory.h | Switch SOF_STACK_SIZE to use CONFIG_SOF_STACK_SIZE for MTL. |
| src/platform/lunarlake/include/platform/lib/memory.h | Switch SOF_STACK_SIZE to use CONFIG_SOF_STACK_SIZE for LNL. |
| src/platform/ace30/include/platform/lib/memory.h | Switch SOF_STACK_SIZE to use CONFIG_SOF_STACK_SIZE for ACE30. |
lgirdwood
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOF_STACK_SIZE (on Intel platforms) is only used to define IDC worker thread stack size. However, we also have a Kconfig option CONFIG_SOF_STACK_SIZE. On some platforms, the IDC worker thread stack used a hard-coded value, which seems to have been an oversight.
The default CONFIG_SOF_STACK_SIZE value is 4096, but it is increased to 8192 on the PTL board and in some overlays, such as the MTL DAX overlay. Therefore, this change also increases the IDC worker thread stack size for those configurations.