Fix: Prevent duplicate CLI errors and unescape AI newlines - #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've implemented a robust error handling mechanism to prevent duplicate error messages from being displayed in the CLI. Previously, errors handled by
ui.PrintErrororui.HandleAppErrorcould still be caught and re-printed by the top-level error handler inmain.go. This change introducesui.Shownandui.IsShownfunctions to explicitly mark errors that have already been presented to the user, ensuring they are not printed again.Additionally, this PR addresses an issue with AI-generated content from the Gemini model. The model occasionally emits literal
escape sequences instead of actual newline characters within Markdown fields like PR bodies and issue descriptions. I've added anunescapeLiteralNewlineshelper function and integrated it into the Gemini service to automatically convert these literal escape sequences into proper newlines, ensuring correct Markdown rendering.Type of Change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
New unit tests were added for the
unescapeLiteralNewlinesfunction ininternal/ai/gemini/helper_test.goand for theShownandIsShownerror wrapping ininternal/ui/ui_test.go.Checklist
Test Plan & Evidence
Suggested Manual Verification
go test ./...and ensure all tests pass