CPD-F02: Add reusable project card component - #507
Conversation
owens-hub-git
left a comment
owens-hub-git
left a comment
There was a problem hiding this comment.
*Just had the same thing with another person.
I'm not sure if this was intended, but it seems you made the pull request to the wrong branch, I made a resource in the OnTrack teams group which shows how and what to push to.
Development is the wrong target branch.
To change this, click the edit icon next to the title and change it to 11.0.x or the team specific branch.
c1a28ee to
692a01a
Compare
692a01a to
6aed655
Compare
|
Thanks Owen, I have updated the PR target branch from development to 11.0.x
and force-updated the branch so the PR now only includes my CPD-F02
project-card component changes.
I’ll follow the OnTrack Teams resource for the correct target branch in
future PRs.
…On Sun, Aug 9, 2026 at 9:24 PM Owen Costin ***@***.***> wrote:
***@***.**** requested changes on this pull request.
*Just had the same thing with another person.
I'm not sure if this was intended, but it seems you made the pull request
to the wrong branch, I made a resource in the OnTrack teams group which
shows how and what to push to.
Development is the wrong target branch.
To change this, click the edit icon next to the title and change it to
11.0.x or the team specific branch.
—
Reply to this email directly, view it on GitHub
<#507?email_source=notifications&email_token=A3QK4RJIEG56PELVSMD63ZD5JBNOXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBZGEZDIMJUG4Y2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4891241471>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3QK4RMMDUGQ6NLZ5DUYF3D5JBNOXAVCNFSNUABFKJSXA33TNF2G64TZHM2DMOJZGQYTIMBZHNEXG43VMU5TKMJQGIYDCNJXHA32C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/A3QK4RPDJ2REGAEJTO47FMD5JBNOXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBZGEZDIMJUG4Y2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/A3QK4RJPUJDUYH7STITP3DL5JBNOXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBZGEZDIMJUG4Y2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
owens-hub-git
left a comment
owens-hub-git
left a comment
There was a problem hiding this comment.
*ngif is not used anymore, been deprecated since Angular 20. Update to use @if instead.
Good resource in this blog: https://blog.angular-university.io/angular-if/
Sorry for the delayed response. During my viva session with Brian, he pointed out that this issue still needed to be addressed, and I realised I had not followed up on the review feedback. I apologise for replying about a week late, and thank you for raising the issue. Updated as requested. I replaced the deprecated *ngIf usages in the project-card template with Angular’s @if control flow. I also corrected the component’s NgModule compatibility and updated the optional-input test. Validation completed: Project-card tests: 4/4 passed The fix is included in commit 251adb8. |
2 participants
Summary
Added a reusable project-card component for the Cross-Project Dashboard task.
What changed
Testing
Evidence
Notes
This PR is limited to the scoped CPD-F02 reusable project-card deliverable and does not implement the full Cross-Project Dashboard.