Skip to content

Stop leaking raw WebAuthn error messages to users in passkey flows #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KaveeshaPiumini merged 1 commit into from
Jul 29, 2026
Merged

Stop leaking raw WebAuthn error messages to users in passkey flows #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/browser/src/utils/handleWebAuthnAuthentication.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,10 @@ const handleWebAuthnAuthentication = async (challengeData: string): Promise<stri

default:
throw new ThunderIDRuntimeError(
`Passkey authentication failed: ${error.message}`,
'Passkey authentication failed. Please try again.',
'browser-webauthn-general-error',
'browser',
`WebAuthn authentication failed with error: ${error.name}`,
`WebAuthn authentication failed with error: ${error.name}: ${error.message}`,
);
}
}
Expand Down
8 changes: 4 additions & 4 deletions packages/react/src/utils/passkey.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ export const handlePasskeyRegistration = async (challengeData: string): Promise<
if (error instanceof Error) {
// Map specific WebAuthn errors to ThunderIDRuntimeError/friendly messages as needed
throw new ThunderIDRuntimeError(
`Passkey registration failed: ${error.message}`,
'Passkey registration failed. Please try again.',
'browser-webauthn-registration-error',
'browser',
`WebAuthn registration failed with error: ${error.name}`,
`WebAuthn registration failed with error: ${error.name}: ${error.message}`,
);
}

Expand Down Expand Up @@ -182,10 +182,10 @@ export const handlePasskeyAuthentication = async (challengeData: string): Promis

if (error instanceof Error) {
throw new ThunderIDRuntimeError(
`Passkey authentication failed: ${error.message}`,
'Passkey authentication failed. Please try again.',
'browser-webauthn-authentication-error',
'browser',
`WebAuthn authentication failed with error: ${error.name}`,
`WebAuthn authentication failed with error: ${error.name}: ${error.message}`,
);
}

Expand Down
8 changes: 4 additions & 4 deletions packages/vue/src/utils/passkey.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ export const handlePasskeyRegistration = async (challengeData: string): Promise<

if (error instanceof Error) {
throw new ThunderIDRuntimeError(
`Passkey registration failed: ${error.message}`,
'Passkey registration failed. Please try again.',
'browser-webauthn-registration-error',
'browser',
`WebAuthn registration failed with error: ${error.name}`,
`WebAuthn registration failed with error: ${error.name}: ${error.message}`,
);
}

Expand Down Expand Up @@ -177,10 +177,10 @@ export const handlePasskeyAuthentication = async (challengeData: string): Promis

if (error instanceof Error) {
throw new ThunderIDRuntimeError(
`Passkey authentication failed: ${error.message}`,
'Passkey authentication failed. Please try again.',
'browser-webauthn-authentication-error',
'browser',
`WebAuthn authentication failed with error: ${error.name}`,
`WebAuthn authentication failed with error: ${error.name}: ${error.message}`,
);
}

Expand Down
Loading