Skip to content

[4413] disable first in voluntary claims - #42

Merged
ThaminduDilshan merged 1 commit into
thunder-id:mainfrom
Infosys:bug/4413
Jul 30, 2026
Merged

[4413] disable first in voluntary claims#42
ThaminduDilshan merged 1 commit into
thunder-id:mainfrom
Infosys:bug/4413

Conversation

@zesu22

@zesu22 zesu22 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Purpose

Disable first while showing voluntary claims, in consent component. Also the same logic will apply in authoptionfactory and signin submission method as well

Approach

Checking if the value of the voluntary claims is true, then only approved value of that claim will be true, otherwise it will always be false only.

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards in WSO2 Secure Coding Guidelines
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

Summary by CodeRabbit

  • Bug Fixes
    • Improved consent handling during sign-in by requiring optional consent inputs to explicitly indicate approval.
    • Prevented ambiguous or unexpected input values from being treated as approved.

Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d93f2013-6278-45e0-ac81-e9b573716562

📥 Commits

Reviewing files that changed from the base of the PR and between ebd7c42 and 654a554.

📒 Files selected for processing (1)
  • packages/react/src/components/presentation/auth/SignIn/SignIn.tsx

📝 Walkthrough

Walkthrough

Sign-in optional consent decisions now require an explicit 'true' processed input and a non-deny action flow to set approved to true.

Changes

Optional consent approval

Layer / File(s) Summary
Tighten optional consent approval calculation
packages/react/src/components/presentation/auth/SignIn/SignIn.tsx
The autogenerated consent_decisions payload now approves optional consent elements only when !isDeny and the processed input equals 'true'.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: brionmario

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the core change: disabling voluntary claims by default.
Description check ✅ Passed The description follows the template and covers purpose, approach, checklist, and security checks; only non-critical items like tests are partially incomplete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ThaminduDilshan
ThaminduDilshan merged commit 191076d into thunder-id:main Jul 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants