OmniOS (illumos) support

[tokenpaul]

Hello.
I tried compile Stalwart mail server on OmniOS and was stuck jemallocator.

Problem 1: configure script fails with message:

  Invalid configuration 'x86_64-unknown-illumos': OS 'illumos' not recognized
  configure: error: /bin/sh ./build-aux/config.sub x86_64-unknown-illumos failed

If I launch configure directly from jemallocator source code folder config.guess determine system type as x86_64-pc-solaris2.11 and problem 2 is appears .

Problem 2: configure script fails with message:

cannot determine return type of strerror_r

This error caused by CFLAG -herror_on_warning which is illegal for linker in Solaris. Error actually is:

ld: fatal: soname option (-h, -soname) is incompatible with building a dynamic executable
ld: fatal: flags processing errors

If I unset -herror_on_warning by ugly hacks than jemallocator will build successfully at least... But I can't build customised crate with Stalwart. It always remove old source code and takes unchanged from a cache.

And good news is jemallocator can be built on OmniOS. :)

Can you help me?

[ti-chi-bot]

Welcome @tokenpaul! It looks like this is your first issue to tikv/jemallocator 🎉

[BusyJay]

For problem 2, you need to fix the compilation issue on jemalloc/jemalloc first。For problem 1, we can update build script to allowlist this tuple.

[tokenpaul]

Ok...
Problem 1 can be fixed by adding a mapping string into tikv-jemalloc-sys/build.rs.

fn gnu_target(target: &str) -> String {
    match target {
        ...
        "x86_64-unknown-illumos" => "x86_64-pc-solaris2.11".to_string(),
        ...
    }    
}

Problem 2 (-herror_on_warning). I have not found any adequate solution and just remove that flag from configure script. Yes, it is highly ugly... but works. Looks like this flag makes trouble if ld needs some shared library. I never seen this flag for C-compilers before and can't realise its purpose. If it for change compiler behaviour to 'die on warning' than -Werror should be enough for GCC. Maybe it should be an option for specific targets?

After that done jemalloc-sys and jemallocator built successfully.
So, jemalloc-sys and jemallocator can be built on Solaris and pass almost tests. See test.log attached

Some reports:

configure
ARGS: --disable-cxx --enable-doc=no --enable-shared=no --with-jemalloc-prefix=rjem --with-private-namespace=rjem --disable-stats

OUTPUT:

CONFIGURE_CFLAGS   : -std=gnu11 -Wall -Wextra -Wsign-compare -Wundef -Wno-format-zero-length -Wpointer-arith -Wno-missing-braces -Wno-missing-field-initializers -Wno-missing-attributes -pipe -g3 -fvisibility=hidden -Wimplicit-fallthrough -Wdeprecated-declarations -O3 -funroll-loops
SPECIFIED_CFLAGS   : -O0 -ffunction-sections -fdata-sections -fPIC -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -m64 -D_REENTRANT -Wall
EXTRA_CFLAGS       :
CPPFLAGS           : -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT
CXX                : g++
CONFIGURE_CXXFLAGS : -fvisibility=hidden -Wimplicit-fallthrough -Wdeprecated-declarations -O3
SPECIFIED_CXXFLAGS :
EXTRA_CXXFLAGS     :
CONFIGURE_LDFLAGS  :
SPECIFIED_LDFLAGS  :
EXTRA_LDFLAGS      :
DSO_LDFLAGS        : -shared -Wl,-soname,$(@F)
LIBS               : -lm -D_POSIX_PTHREAD_SEMANTICS -pthread
RPATH_EXTRA        :

XSLTPROC           : false
XSLROOT            :

PREFIX             : 
BINDIR             : 
DATADIR            : 
INCLUDEDIR         : 
LIBDIR             : 
MANDIR             : 

LG_PAGE            : 12

srcroot            :
abs_srcroot        : 
objroot            :
abs_objroot        : 

JEMALLOC_PREFIX    : _rjem_
JEMALLOC_PRIVATE_NAMESPACE
                   : _rjem_je_
install_suffix     :
malloc_conf        :
documentation      : 0
shared libs        : 0
static libs        : 1
autogen            : 0
debug              : 0
stats              : 0
user_config        : 1
experimental_smallocx : 0
prof               : 0
prof-libunwind     : 0
prof-frameptr      : 0
prof-libgcc        : 0
prof-gcc           : 0
fill               : 1
utrace             : 0
xmalloc            : 0
log                : 0
lazy_lock          : 0
cache-oblivious    : 1
pageid             : 0
cxx                : 0
dss                : 1
tsan               : 0
ubsan              : 0

gmake -i check > test.log 2>&1
FILE ATTACHED: test.log

test.log