Repository navigation
Conversation
Keep fractional penalties through 1.0, cap deductions at available gold, and reject invalid settings. Preserve decimal notation for floating-point INI defaults and cover the calculation with unit tests.
Collaborator
|
|
Contributor
Author
|
Before, players could only lose a server set fraction of their held gold, and values above >=1.0 took all their gold. The new systems still allows all fractions to be usable, but also flat fee when people just put ints without reading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep fractional penalties through 1.0, cap deductions at available gold, and reject invalid settings. Preserve decimal notation for floating-point INI defaults and cover the calculation with unit tests. Tested ingame, flat fee may be less buggy than what people have reported happening before where the fraction did unexpected things.