Repository navigation
Conversation
Author
|
This code was generated by Codex. I apologize if this PR is premature, I didn't exactly ask it to open it and haven't reviewed the code. I am generating bug fixes while I play through with my wife relying on AI and correlated log analysis. I am happy to make adjustments if necessary. |
Collaborator
|
I think there was a reason why
Next time please do some playtesting before submitting a PR. And tell your codex to adhere to our AGENTS.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inventory entries with the same base/enchantment IDs and scalar extra data currently compare equal even when their serialized custom enchantment effects differ. This lets
CanBeMergedandAddOrRemoveEntrymerge distinct payloads or remove the wrong variant, and hides those differences from inventory equality checks.Include
EnchantDatain the existing extra-data comparison, comparing the weapon flag and every effect field. Add focused regressions for magnitude, area, duration, raw cost, effect ID, effect count and enchantment type, plus identical-payload merging/removal. Serialization and native hooks are unchanged.Validation on Windows x64 with VS 2022, xmake 3.1.0,
releasedbg, at commit14710ce4b875a203feb3d3f5df29089ab252b6c4:Inventory.hmade the same tests fail in all seven variant sections (7 failed assertions). Restoring the fix passed all 38 assertions again; tracked sources were clean afterward.In-game custom-enchantment transfer has not been validated. This is a shared inventory value-comparison fix; it does not implement world-drop identity or pickup arbitration.