Show unavailable route distance without numeric overflow - #1724
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unreadable route can report no cross-track distance. Map and Statistics previously formatted its u32::MAX sentinel as a number, which overflowed in checked builds and produced false output in release builds. They now show their existing off-route label without a numeric distance.
Distance rounding uses wider intermediate values. The compact distance buffer and its two transient stat-cell consumers hold the complete u32-range result, including its unit. Normal thresholds, rounding, translations and navigation policy are unchanged. No resident App field changes.
Closes #1722. Parent #1433; program #1448. The original trace came from a truncated browser card followed by replay seek during #1720; its narrower reset checks remain intact.
Validation:
CARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/Users/timo/Documents/OSM/target ./tools/obc test -p obc-app -p obc-route: 1,371 passed (App1,152 unit/integration+4 doc; route215),4 existing ignored doc examples. Real empty/unreadable route sources pass through Navigator to both rendered screens in metric/imperial; text rows match label-only chrome. Formatter maxima and normal crossover cases pass.cargo clippy --locked -p obc-app -p obc-route --all-targets --all-features -- -D warnings: passed.cargo check --locked -p obc-app -p obc-route --no-default-features --target thumbv8m.main-none-eabihfandcargo build --locked -p obc-sim --bin obc-simalso passed. Only normal Map/Statistics frames were rendered; both match their existing manifest hashes.f5e128e95057d3d3ca3928ebbc8f188ce44a55c3fa8e414c026a16f687f05c1b. This includes independently merged Peak View storage changes; this PR changes no resource baseline or ceiling. The selected direct planning chain is40,792 B including common prefix, leaving5,680 B before interrupt/other indirect costs. Physical high-water remains unmeasured on this image.No public documentation changes: this corrects an error label and bounds arithmetic, with no new strings or normal behavior. No full local snapshot/workspace sweep, external fixture download, base/diagnostic firmware build or physical test. CI covers wider consumers.